Bug 239026 - [JSC] Reduce use of unnecessary cryptographicallyRandom numbers
Summary: [JSC] Reduce use of unnecessary cryptographicallyRandom numbers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-08 23:45 PDT by Yusuke Suzuki
Modified: 2022-04-11 13:11 PDT (History)
10 users (show)

See Also:


Attachments
Patch (4.30 KB, patch)
2022-04-08 23:53 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (9.91 KB, patch)
2022-04-09 00:51 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (16.45 KB, patch)
2022-04-10 19:40 PDT, Yusuke Suzuki
saam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-04-08 23:45:30 PDT
[JSC] Use WeakRandom for MarkedBlock Freelist scramble
Comment 1 Yusuke Suzuki 2022-04-08 23:53:03 PDT
Created attachment 457156 [details]
Patch
Comment 2 Yusuke Suzuki 2022-04-09 00:51:07 PDT
Created attachment 457158 [details]
Patch
Comment 3 Yusuke Suzuki 2022-04-10 19:40:37 PDT
Created attachment 457225 [details]
Patch
Comment 4 Saam Barati 2022-04-11 09:20:20 PDT
Comment on attachment 457225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457225&action=review

r=me

> Source/JavaScriptCore/assembler/AbstractMacroAssembler.cpp:37
> +    // No strong cryptographic characteristics is necessary.

is => are
Comment 5 Yusuke Suzuki 2022-04-11 13:04:12 PDT
Comment on attachment 457225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457225&action=review

>> Source/JavaScriptCore/assembler/AbstractMacroAssembler.cpp:37
>> +    // No strong cryptographic characteristics is necessary.
> 
> is => are

Done.
Comment 6 Yusuke Suzuki 2022-04-11 13:10:57 PDT
Committed r292714 (249504@trunk): <https://commits.webkit.org/249504@trunk>
Comment 7 Radar WebKit Bug Importer 2022-04-11 13:11:17 PDT
<rdar://problem/91584856>