Bug 239025 - [JSC] Use Vector with inline capacity in ObjectPropertyConditionSet creation
Summary: [JSC] Use Vector with inline capacity in ObjectPropertyConditionSet creation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-08 22:56 PDT by Yusuke Suzuki
Modified: 2022-04-11 13:04 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.23 KB, patch)
2022-04-08 22:58 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-04-08 22:56:37 PDT
[JSC] Use Vector with inline capacity in ObjectPropertyConditionSet creation
Comment 1 Yusuke Suzuki 2022-04-08 22:58:34 PDT
Created attachment 457151 [details]
Patch
Comment 2 EWS 2022-04-09 15:26:32 PDT
Committed r292682 (249474@main): <https://commits.webkit.org/249474@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457151 [details].
Comment 3 Radar WebKit Bug Importer 2022-04-09 15:27:15 PDT
<rdar://problem/91526803>
Comment 4 Darin Adler 2022-04-11 10:26:06 PDT
Comment on attachment 457151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457151&action=review

> Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.h:59
> +    template<typename Vector>
> +    static ObjectPropertyConditionSet create(Vector&& vector)

Once this is a template argument it’s a universal reference, so pretty sure we should be using std::forward below instead of WTFMove.
Comment 5 Yusuke Suzuki 2022-04-11 13:01:06 PDT
Comment on attachment 457151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457151&action=review

>> Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.h:59
>> +    static ObjectPropertyConditionSet create(Vector&& vector)
> 
> Once this is a template argument it’s a universal reference, so pretty sure we should be using std::forward below instead of WTFMove.

Right! Changed.
Comment 6 Yusuke Suzuki 2022-04-11 13:04:30 PDT
Committed r292713 (249503@trunk): <https://commits.webkit.org/249503@trunk>