Bug 23901 - Add HTML collections V8 custom bindings
Summary: Add HTML collections V8 custom bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-11 13:06 PST by Dimitri Glazkov (Google)
Modified: 2009-02-11 14:37 PST (History)
0 users

See Also:

Attachments
Add HTML options/collections V8 custom bindings, v1 (24.74 KB, patch)
2009-02-11 13:08 PST, Dimitri Glazkov (Google) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-02-11 13:06:17 PST 
... and refactor V8Proxy::ThrowError out.
Comment 1 Dimitri Glazkov (Google) 2009-02-11 13:08:08 PST 
Created attachment 27569 [details]
Add HTML options/collections V8 custom bindings, v1

 WebCore/ChangeLog                                  |   32 +++++
 .../bindings/v8/custom/V8HTMLCollectionCustom.cpp  |  140 ++++++++++++++++++++
 .../bindings/v8/custom/V8HTMLFormElementCustom.cpp |   70 ++++++++++
 .../v8/custom/V8HTMLInputElementCustom.cpp         |   24 ++--
 .../v8/custom/V8HTMLOptionsCollectionCustom.cpp    |   46 +++++++
 .../v8/custom/V8HTMLSelectElementCustom.cpp        |   63 +++++++++
 .../bindings/v8/custom/V8HTMLSelectElementCustom.h |   45 +++++++
 .../bindings/v8/custom/V8NamedNodesCollection.cpp  |   55 ++++++++
 .../bindings/v8/custom/V8NamedNodesCollection.h    |   55 ++++++++
 9 files changed, 516 insertions(+), 14 deletions(-)
Comment 2 Eric Seidel (no email) 2009-02-11 14:03:56 PST 
Comment on attachment 27569 [details]
Add HTML options/collections V8 custom bindings, v1

Upstream doesn't actually have the throwError function yet.  But this looks good!
Comment 3 Dimitri Glazkov (Google) 2009-02-11 14:37:41 PST 
Landed as http://trac.webkit.org/changeset/40873.