RESOLVED FIXED23901
Add HTML collections V8 custom bindings 
https://bugs.webkit.org/show_bug.cgi?id=23901
Summary Add HTML collections V8 custom bindings
Dimitri Glazkov (Google)
Reported 2009-02-11 13:06:17 PST
... and refactor V8Proxy::ThrowError out.
Attachments
Add HTML options/collections V8 custom bindings, v1 (24.74 KB, patch)
2009-02-11 13:08 PST, Dimitri Glazkov (Google) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2009-02-11 13:08:08 PST
Created attachment 27569 [details] Add HTML options/collections V8 custom bindings, v1 WebCore/ChangeLog | 32 +++++ .../bindings/v8/custom/V8HTMLCollectionCustom.cpp | 140 ++++++++++++++++++++ .../bindings/v8/custom/V8HTMLFormElementCustom.cpp | 70 ++++++++++ .../v8/custom/V8HTMLInputElementCustom.cpp | 24 ++-- .../v8/custom/V8HTMLOptionsCollectionCustom.cpp | 46 +++++++ .../v8/custom/V8HTMLSelectElementCustom.cpp | 63 +++++++++ .../bindings/v8/custom/V8HTMLSelectElementCustom.h | 45 +++++++ .../bindings/v8/custom/V8NamedNodesCollection.cpp | 55 ++++++++ .../bindings/v8/custom/V8NamedNodesCollection.h | 55 ++++++++ 9 files changed, 516 insertions(+), 14 deletions(-)
Eric Seidel (no email)
Comment 2 2009-02-11 14:03:56 PST
Comment on attachment 27569 [details] Add HTML options/collections V8 custom bindings, v1 Upstream doesn't actually have the throwError function yet. But this looks good!
Dimitri Glazkov (Google)
Comment 3 2009-02-11 14:37:41 PST
Landed as http://trac.webkit.org/changeset/40873.
Note You need to log in before you can comment on or make changes to this bug.