Bug 239008 - Drop unused pluginReplacementScriptObject
Summary: Drop unused pluginReplacementScriptObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-08 10:53 PDT by Chris Dumez
Modified: 2022-04-08 16:02 PDT (History)
8 users (show)

See Also:

Attachments
Patch (15.38 KB, patch)
2022-04-08 10:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (15.52 KB, patch)
2022-04-08 12:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-04-08 10:53:14 PDT 
Drop unused pluginReplacementScriptObject as it is always null.
Comment 1 Chris Dumez 2022-04-08 10:54:55 PDT 
Created attachment 457096 [details]
Patch
Comment 2 Geoffrey Garen 2022-04-08 12:50:25 PDT 
Comment on attachment 457096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457096&action=review

r=me

> Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:80
> +bool YouTubePluginReplacement::installReplacement(ShadowRoot& root)

Return type can be void, I think.
Comment 3 Chris Dumez 2022-04-08 12:52:45 PDT 
Created attachment 457112 [details]
Patch
Comment 4 EWS 2022-04-08 16:01:53 PDT 
Committed r292641 (249461@main): <https://commits.webkit.org/249461@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457112 [details].
Comment 5 Radar WebKit Bug Importer 2022-04-08 16:02:16 PDT 
<rdar://problem/91507092>