Bug 239004 - [WPE][2.36] Build with a11y disabled fails
Summary: [WPE][2.36] Build with a11y disabled fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-08 08:46 PDT by Philippe Normand
Modified: 2022-04-08 12:55 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2022-04-08 08:48 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (2.74 KB, patch)
2022-04-08 09:25 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2022-04-08 08:46:58 PDT 
../Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp:52:67: error: no member named 'accessibilityBusAddress' in 'WebCore::PlatformDisplay'
        m_dbusAddress = WebCore::PlatformDisplay::sharedDisplay().accessibilityBusAddress().utf8();
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.
Comment 1 Philippe Normand 2022-04-08 08:48:48 PDT 
Created attachment 457076 [details]
Patch
Comment 2 Michael Catanzaro 2022-04-08 09:15:14 PDT 
Comment on attachment 457076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457076&action=review

> Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp:50
>  XDGDBusProxy::XDGDBusProxy(Type type, bool allowPortals)
>      : m_type(type)
>  {
> +#if ENABLE(ACCESSIBILITY)
>      switch (m_type) {
>      case Type::SessionBus:
>          m_dbusAddress = g_getenv("DBUS_SESSION_BUS_ADDRESS");

I think you're removing too much here, right? This will break the non-a11y proxy too?
Comment 3 Philippe Normand 2022-04-08 09:25:40 PDT 
Created attachment 457084 [details]
Patch
Comment 4 EWS 2022-04-08 12:55:49 PDT 
Committed r292628 (249448@main): <https://commits.webkit.org/249448@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457084 [details].