Bug 238998 – REGRESSION (Safari 15.4): Focused element doesn't render outline when it has an underline

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Matt]

When an element has an outline and underline set on it's focus style, the outline isn't rendered.

The following won't render the outline, but setting the text-decoration to none does.
Tabbing back & forth does sometimes show the outline, which is also sometimes partially left there once focus is moved on.

a:focus,
button:focus {
  outline: 6px double blue;
  text-decoration: underline;
}

[Sam Sneddon [:gsnedders]]

> Tabbing back & forth does sometimes show the outline, which is also sometimes partially left there once focus is moved on.

This makes me thinks its a repaint under-invalidation bug?

[zalan]

Created attachment 457078 [details]
Test reduction

[Radar WebKit Bug Importer]

<rdar://problem/91484512>

[zalan]

It looks like ink overflow issue (that we fail to compute the proper ink overflow for outline).

[Radar WebKit Bug Importer]

<rdar://problem/91484572>

[zalan]

Interestingly outline does not show up as ink overflow (as opposed to like text-shadow). Instead it needs some special handling (expanding repaint top/bottom etc) which has not been adopted in the modern line layout integration layer.

[Alexey Proskuryakov]

The double outline is visible when using Safari 15.3 on macOS 12.2.1, so this looks like a regression. I can reproduce with Safari 15.4.

[zalan]

(In reply to Alexey Proskuryakov from comment #7)
> The double outline is visible when using Safari 15.3 on macOS 12.2.1, so
> this looks like a regression. I can reproduce with Safari 15.4.
Sure it is. -> "which has not been adopted in the modern line layout integration layer."

[zalan]

(In reply to zalan from comment #8)
> (In reply to Alexey Proskuryakov from comment #7)
> > The double outline is visible when using Safari 15.3 on macOS 12.2.1, so
> > this looks like a regression. I can reproduce with Safari 15.4.
> Sure it is. -> "which has not been adopted in the modern line layout
> integration layer."
I should have been more explicit about it by adding the regression prefix.

[zalan]

Created attachment 457126 [details]
Patch

[zalan]

Created attachment 457160 [details]
Patch

[EWS]

Committed r292679 (249471@main): <https://commits.webkit.org/249471@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457160 [details].