Bug 238978 - Fix accessibility/aria-invalid.html in isolated tree mode
Summary: Fix accessibility/aria-invalid.html in isolated tree mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-07 20:17 PDT by Tyler Wilcock
Modified: 2022-04-10 00:30 PDT (History)
10 users (show)

See Also:


Attachments
Patch (14.29 KB, patch)
2022-04-07 20:24 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (14.29 KB, patch)
2022-04-07 23:10 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (13.96 KB, patch)
2022-04-08 11:54 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-04-07 20:17:48 PDT
Fix accessibility/aria-invalid.html in isolated tree mode
Comment 1 Radar WebKit Bug Importer 2022-04-07 20:17:58 PDT
<rdar://problem/91460480>
Comment 2 Tyler Wilcock 2022-04-07 20:24:26 PDT
Created attachment 457007 [details]
Patch
Comment 3 Tyler Wilcock 2022-04-07 23:10:05 PDT
Created attachment 457024 [details]
Patch
Comment 4 Andres Gonzalez 2022-04-08 05:16:26 PDT
(In reply to Tyler Wilcock from comment #3)
> Created attachment 457024 [details]
> Patch

--- a/LayoutTests/resources/accessibility-helper.js
+++ a/LayoutTests/resources/accessibility-helper.js

+    const evalExpression = `${expression} === ${expectedValue}`;
+    if (eval(evalExpression))
+        return `PASS: ${evalExpression}\n`;
+    else
+        return `FAIL: ${expression} !== ${expectedValue}\n`;

Can we write this more succinctly as

+    if (eval(`${expression} === ${expectedValue}`))
+        return `PASS: ${evalExpression}\n`;
+    return `FAIL: ${expression} !== ${expectedValue}\n`;
Comment 5 Tyler Wilcock 2022-04-08 11:54:29 PDT
Created attachment 457106 [details]
Patch
Comment 6 EWS 2022-04-10 00:30:20 PDT
Committed r292686 (249478@main): <https://commits.webkit.org/249478@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457106 [details].