WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED CONFIGURATION CHANGED
238964
REGRESSION(
247678@main
) [WPE] API test TestUIClient /webkit/WebKitWebView/allow-modal-dialogs is making run-wpe-tests to timeout
https://bugs.webkit.org/show_bug.cgi?id=238964
Summary
REGRESSION(247678@main) [WPE] API test TestUIClient /webkit/WebKitWebView/all...
Lauro Moura
Reported
2022-04-07 15:20:35 PDT
/TestWebKitAPI/WPE/TestUIClient /webkit/WebKitWebView/allow-modal-dialogs The test passes but `run-wpe-tests` has been timing out consistently in WPE bots waiting for the TestUIClient executable to return. Reverting this commit or commenting out this test makes the test to exit correctly, as does adding a small timeout to give the loop a few more spins before exiting.
Attachments
Tentative patch
(1.58 KB, patch)
2022-04-07 15:35 PDT
,
Lauro Moura
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Lauro Moura
Comment 1
2022-04-07 15:35:31 PDT
Created
attachment 456975
[details]
Tentative patch Tentative patch by adding the wait time. Not sure if the original patch actually uncovered some limitation in the modal dialog implementation (although the test uses showModalDialog which is deprecated in HTML).
Lauro Moura
Comment 2
2022-05-31 20:49:45 PDT
Looks like something between
249870@main
and
250658@main
fixed the issue and the tests are working now. Closing.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug