Bug 238964 - REGRESSION(247678@main) [WPE] API test TestUIClient /webkit/WebKitWebView/allow-modal-dialogs is making run-wpe-tests to timeout
Summary: REGRESSION(247678@main) [WPE] API test TestUIClient /webkit/WebKitWebView/all...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-07 15:20 PDT by Lauro Moura
Modified: 2022-05-31 20:49 PDT (History)
1 user (show)

See Also:

Attachments
Tentative patch (1.58 KB, patch)
2022-04-07 15:35 PDT, Lauro Moura 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2022-04-07 15:20:35 PDT 
/TestWebKitAPI/WPE/TestUIClient /webkit/WebKitWebView/allow-modal-dialogs

The test passes but `run-wpe-tests` has been timing out consistently in WPE bots waiting for the TestUIClient executable to return.

Reverting this commit or commenting out this test makes the test to exit correctly, as does adding a small timeout to give the loop a few more spins before exiting.
Comment 1 Lauro Moura 2022-04-07 15:35:31 PDT 
Created attachment 456975 [details]
Tentative patch

Tentative patch by adding the wait time. Not sure if the original patch actually uncovered some limitation in the modal dialog implementation (although the test uses showModalDialog which is deprecated in HTML).
Comment 2 Lauro Moura 2022-05-31 20:49:45 PDT 
Looks like something between 249870@main and 250658@main fixed the issue and the tests are working now. Closing.