Bug 238962 – [WebAuthn] Ensure requestPin callback on main thread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[[e-mail]]

When performing requests via ASA, this callback causes asserts to fail in debug builds.

[Radar WebKit Bug Importer]

<rdar://problem/91446051>

[[e-mail]]

Created attachment 456974 [details]
Patch

[Brent Fulgham]

Comment on attachment 456974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456974&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:138
> +            completionHandler(pin.get());

I recommend adding a RELEASE_ASSERT(isMainThread()) to the logic of the completion handler to avoid future mistakes.

[Brent Fulgham]

Comment on attachment 456974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456974&action=review

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:138
>> +            completionHandler(pin.get());
> 
> I recommend adding a RELEASE_ASSERT(isMainThread()) to the logic of the completion handler to avoid future mistakes.

Actually, I see you are using the more-correct RunLoop::isMain() in the caller, so no other action needed (except perhaps making it a RELEASE_ASSERT, which might be important to prevent UIKit code from ever running on a background thread.

[[e-mail]]

Created attachment 457094 [details]
Patch for landing

[EWS]

Committed r292710 (249501@main): <https://commits.webkit.org/249501@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457094 [details].