Bug 238948 - [MSE] Improve SourceBuffer memory cost reporting
Summary: [MSE] Improve SourceBuffer memory cost reporting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-07 11:12 PDT by Enrique Ocaña
Modified: 2022-04-22 04:42 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.82 KB, patch)
2022-04-07 11:25 PDT, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Patch (4.81 KB, patch)
2022-04-19 06:41 PDT, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2022-04-07 11:12:23 PDT 
Properly implementing the memoryCost() API in SourceBuffer would improve memory awareness when garbage collecting.
Comment 1 Enrique Ocaña 2022-04-07 11:25:41 PDT 
Created attachment 456950 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-04-14 11:13:12 PDT 
<rdar://problem/91765758>
Comment 3 Enrique Ocaña 2022-04-19 06:41:28 PDT 
Created attachment 457884 [details]
Patch
Comment 4 Enrique Ocaña 2022-04-19 06:44:50 PDT 
This latest patch returns m_extraMemoryCost instead of m_reportedExtraMemoryCost (which was a mistake) in SourceBuffer::memoryCost().
Comment 5 EWS 2022-04-22 04:42:08 PDT 
Committed r293216 (249885@main): <https://commits.webkit.org/249885@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457884 [details].