Bug 238941 - [JSC] Fix compile warnings
Summary: [JSC] Fix compile warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail R. Gadelha
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-07 09:24 PDT by Mikhail R. Gadelha
Modified: 2022-04-19 07:59 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2022-04-07 09:25 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Patch (3.85 KB, patch)
2022-04-18 17:16 PDT, Mikhail R. Gadelha 		ysuzuki: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail R. Gadelha 2022-04-07 09:24:23 PDT 
[JSC] Fix compile warnings
Comment 1 Mikhail R. Gadelha 2022-04-07 09:25:24 PDT 
Created attachment 456937 [details]
Patch
Comment 2 Yusuke Suzuki 2022-04-08 11:22:04 PDT 
r-, this is not OK. This function is *super* hot, and any kind of these addition can hurt performance.
Use IGNORE_RETURN_TYPE_WARNINGS_BEGIN / IGNORE_RETURN_TYPE_WARNINGS_END instead.
Comment 3 Mikhail R. Gadelha 2022-04-08 11:27:57 PDT 
Are you sure it's that bad? These are only inserted after the switches... is it because they might be inlined?

We can also use ASSERT_NOT_REACHED instead, WDYT?
Comment 4 Geza Lore 2022-04-11 03:41:48 PDT 
ASSERT_NOT_REACHED is `((void)0)` on the release build so you would probably still get the warnings.
Comment 5 Radar WebKit Bug Importer 2022-04-14 09:25:14 PDT 
<rdar://problem/91757981>
Comment 6 Mikhail R. Gadelha 2022-04-18 17:16:09 PDT 
Created attachment 457843 [details]
Patch
Comment 7 Yusuke Suzuki 2022-04-18 17:22:50 PDT 
Comment on attachment 457843 [details]
Patch

r=me
Comment 8 Mikhail R. Gadelha 2022-04-19 07:59:02 PDT 
Already fixed on ToT.