Bug 238938 - Remove unneeded CoreIPC messages + handlers related to StorageManagerSet.
Summary: Remove unneeded CoreIPC messages + handlers related to StorageManagerSet.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin
URL:
Keywords: InRadar
: 211157 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-04-07 08:18 PDT by Gavin
Modified: 2022-07-01 11:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (9.01 KB, patch)
2022-04-07 08:21 PDT, Gavin 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (9.33 KB, patch)
2022-04-07 09:07 PDT, Gavin 		no flags Details | Formatted Diff | Diff
Patch (39.16 KB, patch)
2022-04-07 11:50 PDT, Gavin 		no flags Details | Formatted Diff | Diff
Patch (39.19 KB, patch)
2022-04-08 07:56 PDT, Gavin 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin 2022-04-07 08:18:01 PDT 
Remove unneeded CoreIPC messages + handlers related to StorageManagerSet.
Comment 1 Gavin 2022-04-07 08:21:26 PDT 
Created attachment 456928 [details]
Patch
Comment 2 Gavin 2022-04-07 08:22:24 PDT 
I think we can probably remove some of the implementation too. But wanted to do an initial EWS pass to confirm these aren't needed.
Comment 3 Gavin 2022-04-07 09:07:57 PDT 
Created attachment 456933 [details]
Patch
Comment 4 Gavin 2022-04-07 11:50:33 PDT 
Created attachment 456952 [details]
Patch
Comment 5 Chris Dumez 2022-04-08 07:25:03 PDT 
Comment on attachment 456952 [details]
Patch

r=me
Comment 6 EWS 2022-04-08 07:34:30 PDT 
/Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 7 Gavin 2022-04-08 07:56:42 PDT 
Created attachment 457069 [details]
Patch
Comment 8 Gavin 2022-04-08 07:58:03 PDT 
@Chris - please can I get another r?. I've not changed the code, I've just updated the change log as I previously deleted the "Reviewed by NOBODY (OOPS!)." and commit-queue got upset.
Comment 9 Chris Dumez 2022-04-08 08:01:15 PDT 
(In reply to Gavin from comment #8)
> @Chris - please can I get another r?. I've not changed the code, I've just
> updated the change log as I previously deleted the "Reviewed by NOBODY
> (OOPS!)." and commit-queue got upset.

Sure, but in the future, you can just put my name as the reviewer in the ChangeLog to avoid that.
Comment 10 EWS 2022-04-08 13:28:14 PDT 
Committed r292631 (249451@main): <https://commits.webkit.org/249451@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457069 [details].
Comment 11 Radar WebKit Bug Importer 2022-04-08 13:29:16 PDT 
<rdar://problem/91499896>
Comment 12 Alex Christensen 2022-07-01 11:57:10 PDT 
*** Bug 211157 has been marked as a duplicate of this bug. ***