Bug 238931 – [web-animations] REGRESSION (r287881): loading performance for diply.com regressed

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

[web-animations] REGRESSION (r287881): loading performance for diply.com regressed

[Antoine Quint]

Created attachment 456918 [details]
Patch

[Antoine Quint]

<rdar://problem/91190007>

[Simon Fraser (smfr)]

Comment on attachment 456918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456918&action=review

> Source/WebCore/style/Styleable.cpp:451
> +    auto effectTargetsProperty = [&](KeyframeEffect& effect) {
> +        if (effect.animatedProperties().contains(property))
> +            return true;
> +        if (auto* transition = dynamicDowncast<CSSTransition>(effect.animation()))
> +            return transition->property() == property;
> +        return false;
> +    };

Might be cleaner to pass `property` in and remove default capture.

[Antoine Quint]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 456918 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456918&action=review
> 
> > Source/WebCore/style/Styleable.cpp:451
> > +    auto effectTargetsProperty = [&](KeyframeEffect& effect) {
> > +        if (effect.animatedProperties().contains(property))
> > +            return true;
> > +        if (auto* transition = dynamicDowncast<CSSTransition>(effect.animation()))
> > +            return transition->property() == property;
> > +        return false;
> > +    };
> 
> Might be cleaner to pass `property` in and remove default capture.

Had the same thought as I was writing but was too lazy! Will fix in the commit.

[Antoine Quint]

Created attachment 456943 [details]
Patch for landing

[EWS]

Committed r292561 (249399@main): <https://commits.webkit.org/249399@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456943 [details].