Bug 238931 - [web-animations] REGRESSION (r287881): loading performance for diply.com regressed
Summary: [web-animations] REGRESSION (r287881): loading performance for diply.com regr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-07 06:42 PDT by Antoine Quint
Modified: 2022-04-07 13:33 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.86 KB, patch)
2022-04-07 06:43 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (2.86 KB, patch)
2022-04-07 10:54 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-04-07 06:42:23 PDT
[web-animations] REGRESSION (r287881): loading performance for diply.com regressed
Comment 1 Antoine Quint 2022-04-07 06:43:47 PDT
Created attachment 456918 [details]
Patch
Comment 2 Antoine Quint 2022-04-07 06:43:53 PDT
<rdar://problem/91190007>
Comment 3 Simon Fraser (smfr) 2022-04-07 09:42:16 PDT
Comment on attachment 456918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456918&action=review

> Source/WebCore/style/Styleable.cpp:451
> +    auto effectTargetsProperty = [&](KeyframeEffect& effect) {
> +        if (effect.animatedProperties().contains(property))
> +            return true;
> +        if (auto* transition = dynamicDowncast<CSSTransition>(effect.animation()))
> +            return transition->property() == property;
> +        return false;
> +    };

Might be cleaner to pass `property` in and remove default capture.
Comment 4 Antoine Quint 2022-04-07 10:45:45 PDT
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 456918 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456918&action=review
> 
> > Source/WebCore/style/Styleable.cpp:451
> > +    auto effectTargetsProperty = [&](KeyframeEffect& effect) {
> > +        if (effect.animatedProperties().contains(property))
> > +            return true;
> > +        if (auto* transition = dynamicDowncast<CSSTransition>(effect.animation()))
> > +            return transition->property() == property;
> > +        return false;
> > +    };
> 
> Might be cleaner to pass `property` in and remove default capture.

Had the same thought as I was writing but was too lazy! Will fix in the commit.
Comment 5 Antoine Quint 2022-04-07 10:54:43 PDT
Created attachment 456943 [details]
Patch for landing
Comment 6 EWS 2022-04-07 13:33:43 PDT
Committed r292561 (249399@main): <https://commits.webkit.org/249399@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456943 [details].