Bug 238929 - Move long-enabled preferences away from experimental
Summary: Move long-enabled preferences away from experimental
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-07 06:24 PDT by Sam Sneddon [:gsnedders]
Modified: 2023-05-31 14:21 PDT (History)
6 users (show)

See Also:


Attachments
Patch (31.44 KB, patch)
2022-04-07 06:25 PDT, Sam Sneddon [:gsnedders]
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (31.46 KB, patch)
2022-04-07 08:37 PDT, Sam Sneddon [:gsnedders]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2022-04-07 06:24:47 PDT
Move long-enabled preferences away from experimental
Comment 1 Sam Sneddon [:gsnedders] 2022-04-07 06:25:53 PDT
Created attachment 456916 [details]
Patch
Comment 2 Sam Sneddon [:gsnedders] 2022-04-07 08:37:32 PDT
Created attachment 456930 [details]
Patch
Comment 3 Tim Horton 2022-04-07 10:14:28 PDT
Comment on attachment 456930 [details]
Patch

Very nice!
Comment 4 Brent Fulgham 2022-04-07 10:19:36 PDT
Comment on attachment 456930 [details]
Patch

Nice!
Comment 5 EWS 2022-04-07 18:36:15 PDT
Committed r292586 (249419@main): <https://commits.webkit.org/249419@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456930 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-07 18:37:16 PDT
<rdar://problem/91457743>
Comment 7 Truitt Savell 2022-04-08 16:41:36 PDT
Reverted r292586 for reason:

Caused 50+ test failures on Mac wk1

Committed r292642 (249462@trunk): <https://commits.webkit.org/249462@trunk>
Comment 9 Tim Horton 2022-04-15 23:59:10 PDT
The trick here, I think, is that moving them from Experimental to normal means they no longer get implicitly enabled by DRT. Previously, ReferrerPolicyAttributeEnabled was disabled by default in WebKit1, but enabled in DRT (along with all other experimental features). Now it's disabled by default in WebKit1, period, and the tests fail.
Comment 10 Sam Sneddon [:gsnedders] 2023-05-31 13:28:04 PDT
We've done a lot of work on tidying up preferences over the past year, so it seems like this can probably be safely closed?
Comment 11 Brent Fulgham 2023-05-31 14:21:55 PDT
Oh yes! Thank you.