Bug 238929 – Move long-enabled preferences away from experimental

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: New Bugs

[Sam Sneddon [:gsnedders]]

Move long-enabled preferences away from experimental

[Sam Sneddon [:gsnedders]]

Created attachment 456916 [details]
Patch

[Sam Sneddon [:gsnedders]]

Created attachment 456930 [details]
Patch

[Tim Horton]

Comment on attachment 456930 [details]
Patch

Very nice!

[Brent Fulgham]

Comment on attachment 456930 [details]
Patch

Nice!

[EWS]

Committed r292586 (249419@main): <https://commits.webkit.org/249419@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456930 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91457743>

[Truitt Savell]

Reverted r292586 for reason:

Caused 50+ test failures on Mac wk1

Committed r292642 (249462@trunk): <https://commits.webkit.org/249462@trunk>

[Truitt Savell]

for context we began seeing g50+ failures on Mac wk1 from this change. This was causing ews runs to exit early for wk1.

Build:
https://build.webkit.org/#/builders/48/builds/9431

Results:
https://build.webkit.org/results/Apple-BigSur-Release-WK1-Tests/r292634%20(9431)/results.html


Example history:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Freferrer-policy-anchor%2Forigin-when-cross-origin%2Fcross-origin-http.https.html

[Tim Horton]

The trick here, I think, is that moving them from Experimental to normal means they no longer get implicitly enabled by DRT. Previously, ReferrerPolicyAttributeEnabled was disabled by default in WebKit1, but enabled in DRT (along with all other experimental features). Now it's disabled by default in WebKit1, period, and the tests fail.

[Sam Sneddon [:gsnedders]]

We've done a lot of work on tidying up preferences over the past year, so it seems like this can probably be safely closed?

[Brent Fulgham]

Oh yes! Thank you.