Bug 238927 - Split TestWebKitAPI.GPUProcess.ExitsUnderMemoryPressureWebRTCCase in more tests
Summary: Split TestWebKitAPI.GPUProcess.ExitsUnderMemoryPressureWebRTCCase in more tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-07 05:36 PDT by youenn fablet
Modified: 2022-04-12 07:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.85 KB, patch)
2022-04-07 05:38 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (5.48 KB, patch)
2022-04-07 08:27 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (5.47 KB, patch)
2022-04-08 04:14 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-04-07 05:36:47 PDT 
Split TestWebKitAPI.GPUProcess.ExitsUnderMemoryPressureWebRTCCase in more tests
Comment 1 youenn fablet 2022-04-07 05:38:29 PDT 
Created attachment 456915 [details]
Patch
Comment 2 youenn fablet 2022-04-07 08:27:42 PDT 
Created attachment 456929 [details]
Patch
Comment 3 Eric Carlson 2022-04-07 09:08:42 PDT 
Comment on attachment 456929 [details]
Patch

r=me once the bots are happy
Comment 4 youenn fablet 2022-04-08 04:14:10 PDT 
Created attachment 457042 [details]
Patch for landing
Comment 5 EWS 2022-04-11 01:31:00 PDT 
Committed r292705 (249497@main): <https://commits.webkit.org/249497@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457042 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-11 01:32:15 PDT 
<rdar://problem/91553348>
Comment 7 youenn fablet 2022-04-12 00:44:55 PDT 
The issue seems related with audio capture.
I'll update the tests to prevent flakiness on bots.
Comment 8 Chris Dumez 2022-04-12 07:14:04 PDT 
(In reply to youenn fablet from comment #7)
> The issue seems related with audio capture.
> I'll update the tests to prevent flakiness on bots.

Why is updating the test the right thing to do? Isn't it indicative of a bug where the GPUProcess gets relaunched unnecessarily after a crash?

That's the whole point of this test.
Comment 9 youenn fablet 2022-04-12 07:19:25 PDT 
(In reply to Chris Dumez from comment #8)
> (In reply to youenn fablet from comment #7)
> > The issue seems related with audio capture.
> > I'll update the tests to prevent flakiness on bots.
> 
> Why is updating the test the right thing to do? Isn't it indicative of a bug
> where the GPUProcess gets relaunched unnecessarily after a crash?
> 
> That's the whole point of this test.

The test was initially disabled to reduce EWS load. I split it to investigate.
I am now disabling the sub test to reduce EWS load again.
I still plan to investigate the underlying issue so that we can reenable the test in bots.
Comment 10 Chris Dumez 2022-04-12 07:20:57 PDT 
(In reply to youenn fablet from comment #9)
> (In reply to Chris Dumez from comment #8)
> > (In reply to youenn fablet from comment #7)
> > > The issue seems related with audio capture.
> > > I'll update the tests to prevent flakiness on bots.
> > 
> > Why is updating the test the right thing to do? Isn't it indicative of a bug
> > where the GPUProcess gets relaunched unnecessarily after a crash?
> > 
> > That's the whole point of this test.
> 
> The test was initially disabled to reduce EWS load. I split it to
> investigate.
> I am now disabling the sub test to reduce EWS load again.
> I still plan to investigate the underlying issue so that we can reenable the
> test in bots.

Oh, I misunderstood. Ok.