Bug 238902 - [:has() pseudo-class] Support invalidation for :in-range/:out-of-range
Summary: [:has() pseudo-class] Support invalidation for :in-range/:out-of-range
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks: 234556 240762
  Show dependency tree / graph
 
Reported: 2022-04-06 15:29 PDT by Tim Nguyen (:ntim)
Modified: 2022-05-21 12:34 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.29 KB, patch)
2022-05-20 03:35 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (5.08 KB, patch)
2022-05-20 04:52 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (5.26 KB, patch)
2022-05-21 01:21 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (5.11 KB, patch)
2022-05-21 02:41 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-04-06 15:29:20 PDT 
:in-range/:out-of-range

should be a matter of using Style::PseudoClassChangeInvalidation instead of invalidateStyleForSubtree() where appropriate.
Comment 1 Radar WebKit Bug Importer 2022-04-13 15:30:13 PDT 
<rdar://problem/91718746>
Comment 2 Antti Koivisto 2022-05-20 03:35:08 PDT 
Created attachment 459612 [details]
Patch
Comment 3 Antti Koivisto 2022-05-20 04:52:51 PDT 
Created attachment 459613 [details]
Patch
Comment 4 Tim Nguyen (:ntim) 2022-05-20 09:57:38 PDT 
Comment on attachment 459613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459613&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt:10
> +PASS :out-of-range invalidation

There are cases this doesn't cover fwiw:
- type attribute change
- min/max attribute change

Might be worth extending the test, and adding support if necessary
Comment 5 Antti Koivisto 2022-05-21 01:21:21 PDT 
Created attachment 459637 [details]
Patch
Comment 6 Antti Koivisto 2022-05-21 01:22:16 PDT 
> There are cases this doesn't cover fwiw:
> - type attribute change
> - min/max attribute change
> 
> Might be worth extending the test, and adding support if necessary

Good future tasks.
Comment 7 Antti Koivisto 2022-05-21 02:41:11 PDT 
Created attachment 459638 [details]
Patch
Comment 8 EWS 2022-05-21 08:15:15 PDT 
Committed r294613 (250839@main): <https://commits.webkit.org/250839@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459638 [details].