Bug 238899 - [:has() pseudo-class] Support invalidation for autofill pseudo classes
Summary: [:has() pseudo-class] Support invalidation for autofill pseudo classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: 234556
  Show dependency tree / graph
 
Reported: 2022-04-06 15:26 PDT by Tim Nguyen (:ntim)
Modified: 2022-04-07 06:00 PDT (History)
8 users (show)

See Also:

Attachments
[fast-cq] Patch (8.19 KB, patch)
2022-04-06 23:45 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-04-06 15:26:16 PDT 
There are multiple autofill pseudo classes, it should be a matter of using PseudoClassChangeInvalidation instead of invalidateStyleForSubtree().
Comment 1 Tim Nguyen (:ntim) 2022-04-06 23:45:19 PDT 
Created attachment 456895 [details]
[fast-cq] Patch
Comment 2 Antti Koivisto 2022-04-07 05:45:41 PDT 
Comment on attachment 456895 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456895&action=review

> LayoutTests/ChangeLog:9
> +        * fast/forms/input-autofilled-expected.txt:
> +        * fast/forms/input-autofilled.html:

Please add (or expand) a WPT.
Comment 3 Tim Nguyen (:ntim) 2022-04-07 05:55:50 PDT 
Comment on attachment 456895 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456895&action=review

>> LayoutTests/ChangeLog:9
>> +        * fast/forms/input-autofilled.html:
> 
> Please add (or expand) a WPT.

You can't use `window.internals.setAutofilled(input, true);` in WPT unfortunately.
Comment 4 EWS 2022-04-07 05:59:10 PDT 
Committed r292531 (249369@main): <https://commits.webkit.org/249369@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456895 [details].
Comment 5 Radar WebKit Bug Importer 2022-04-07 06:00:16 PDT 
<rdar://problem/91410097>