The build currently fails when trying to turn on the address sanitizer using the gcc compiler.
Created attachment 456823 [details] Patch
<rdar://problem/91692190>
Comment on attachment 456823 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456823&action=review > Source/JavaScriptCore/runtime/ConfigFile.cpp:248 > m_filename[s_maxPathLength] = '\0'; Missing _END before leaving scope?
Created attachment 457803 [details] Patch
(In reply to Philippe Normand from comment #3) > Comment on attachment 456823 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456823&action=review > > > Source/JavaScriptCore/runtime/ConfigFile.cpp:248 > > m_filename[s_maxPathLength] = '\0'; > > Missing _END before leaving scope? Oof. Yes. Thanks for spotting that. I've uploaded a new version of the change.
Found 1 new test failure: http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html
Committed r293010 (249749@main): <https://commits.webkit.org/249749@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457803 [details].