Bug 238860 – ServiceWorkerDownloadTask starts listening for IPC in constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Kimmo Kinnunen]

ServiceWorkerDownloadTask starts listening for IPC in constructor

[Kimmo Kinnunen]

Created attachment 456803 [details]
Patch

[Kimmo Kinnunen]

Created attachment 456804 [details]
Patch

[youenn fablet]

Comment on attachment 456804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456804&action=review

> Source/WebKit/ChangeLog:10
> +        virtual function table of the `this` object has not been constructed fully yet. This means

I am not sure this is entirely exact, ServiceWorkerDownloadTask is the derived class.
In any case, calling virtual methods in constructor is probably best be avoided.

[Kimmo Kinnunen]

(In reply to youenn fablet from comment #3)
> > Source/WebKit/ChangeLog:10
> > +        virtual function table of the `this` object has not been constructed fully yet. This means
> 
> I am not sure this is entirely exact, ServiceWorkerDownloadTask is the
> derived class.
> In any case, calling virtual methods in constructor is probably best be
> avoided.

This is exactly the case with the derived classes.
vptr is not thread-safe -- it will be correct only after all constructors have returned.

[EWS]

Committed r292471 (249322@main): <https://commits.webkit.org/249322@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456804 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91356880>