Bug 238857 - Remove some @apply leftover code
Summary: Remove some @apply leftover code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-06 01:15 PDT by Antti Koivisto
Modified: 2022-04-06 02:18 PDT (History)
8 users (show)

See Also:

Attachments
Patch (10.05 KB, patch)
2022-04-06 01:18 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2022-04-06 01:15:37 PDT 
@apply is not a thing.
Comment 1 Antti Koivisto 2022-04-06 01:18:21 PDT 
Created attachment 456789 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2022-04-06 01:37:42 PDT 
Comment on attachment 456789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456789&action=review

> Source/WebCore/css/parser/CSSVariableParser.cpp:91
> +        case AtKeywordToken:
>              break;

Is it possible to delete this? `default:` bellow seems to handle it.
Comment 3 Antti Koivisto 2022-04-06 01:56:42 PDT 
> Is it possible to delete this? `default:` bellow seems to handle it.

A better direction might be to eliminate the default branch. Then everyone who adds a new token type needs to consider this code too.
Comment 4 EWS 2022-04-06 02:17:51 PDT 
Committed r292455 (249306@main): <https://commits.webkit.org/249306@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456789 [details].
Comment 5 Radar WebKit Bug Importer 2022-04-06 02:18:18 PDT 
<rdar://problem/91342745>