Bug 238851 – Unify the two ImageBuffer::create() functions, passing RenderingPurpose everywhere

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

Unify the two ImageBuffer::create() functions, passing RenderingPurpose everywhere

[Simon Fraser (smfr)]

Created attachment 456766 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 456768 [details]
Patch

[Said Abou-Hallawa]

Comment on attachment 456768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456768&action=review

> Source/WebCore/platform/graphics/ImageBuffer.h:67
> +    WEBCORE_EXPORT static RefPtr<ImageBuffer> create(const FloatSize&, OptionSet<ImageBufferOptions>, RenderingPurpose, float resolutionScale, const DestinationColorSpace&, PixelFormat, const CreationContext& = { });

I think ImageBufferOptions can be moved to the end just before CreationContext and it can have a default value { }. So many callers do not have to pass { } for it.

> Source/WebCore/platform/graphics/RenderingMode.h:47
> +enum class ImageBufferOptions : uint8_t {

Should this be moved to ImageBuffer.h since it is only used for ImageBuffer?

> Source/WebCore/platform/graphics/filters/software/FETileSoftwareApplier.cpp:54
> +    OptionSet<ImageBufferOptions> bufferOptions;
> +    if (filter.renderingMode() == RenderingMode::Accelerated)
> +        bufferOptions.add(ImageBufferOptions::Accelerated);

This code is repeated many times in the patch. Can't we add an inline function in RenderingMode.h

inline OptionSet<ImageBufferOptions> bufferOptions(RenderingMode renderringMode)
{

}

Or something else. And use this inline directly in the call to ImageBuffer::create(tileRect.size(), bufferOptions(filter.renderingMode()), ...).

[Simon Fraser (smfr)]

Created attachment 456778 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 456779 [details]
Patch

[EWS]

Committed r292469 (249320@main): <https://commits.webkit.org/249320@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456779 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91354760>

[Darin Adler]

There’s a "RendingMode" typo in here.

I suggest grepping for "endingMode".