Bug 238848 - FilterImage::imageBufferFromPixelBuffer() can trigger accelerated buffers in the web process
Summary: FilterImage::imageBufferFromPixelBuffer() can trigger accelerated buffers in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 238889 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-04-05 16:12 PDT by Simon Fraser (smfr)
Modified: 2022-04-06 15:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2022-04-06 14:00 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-04-05 16:12:35 PDT
FilterImage::imageBufferFromPixelBuffer() makes an accelerated buffer, but doesn't use a RenderingPurpose option, so can trigger accelerated rendering in the web process. This will break when IOKit blocking is enabled.
Comment 1 Radar WebKit Bug Importer 2022-04-05 16:12:51 PDT
<rdar://problem/91322362>
Comment 2 Simon Fraser (smfr) 2022-04-05 16:21:02 PDT
Said says this code only runs in the GPUP.
Comment 3 Simon Fraser (smfr) 2022-04-06 13:56:12 PDT
I verified that this is only called in the GPU process.
Comment 4 Simon Fraser (smfr) 2022-04-06 13:57:46 PDT
I'll use this to remove the comment.
Comment 5 Simon Fraser (smfr) 2022-04-06 13:59:09 PDT
*** Bug 238889 has been marked as a duplicate of this bug. ***
Comment 6 Simon Fraser (smfr) 2022-04-06 14:00:19 PDT
Created attachment 456858 [details]
Patch
Comment 7 EWS 2022-04-06 15:22:52 PDT
Committed r292511 (249353@main): <https://commits.webkit.org/249353@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456858 [details].