Bug 238843 - Web Inspector: Regression(r291729) The result of logging $0 to the console shows overlapping `$0` and `$[n]` after the node
Summary: Web Inspector: Regression(r291729) The result of logging $0 to the console sh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on: 238226
Blocks:
  Show dependency tree / graph
 
Reported: 2022-04-05 15:34 PDT by Patrick Angle
Modified: 2022-04-05 16:54 PDT (History)
4 users (show)

See Also:

Attachments
Screenshot of Issue (32.26 KB, image/png)
2022-04-05 15:34 PDT, Patrick Angle 		no flags Details
Patch v1.0 (2.34 KB, patch)
2022-04-05 15:37 PDT, Patrick Angle 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2022-04-05 15:34:17 PDT 
Created attachment 456760 [details]
Screenshot of Issue

r291729 is missing a check that the `DOMTreeOutline` is actually supposed to show an indicator for the inspected node, which means other usage of `DOMTreeOutline` (the console, the sources tab, etc.) are showing the $0 indicator as well now.
Comment 1 Radar WebKit Bug Importer 2022-04-05 15:34:28 PDT 
<rdar://problem/91319491>
Comment 2 Patrick Angle 2022-04-05 15:37:17 PDT 
Created attachment 456761 [details]
Patch v1.0
Comment 3 Devin Rousso 2022-04-05 15:39:29 PDT 
Comment on attachment 456761 [details]
Patch v1.0

rs=me
Comment 4 EWS 2022-04-05 16:54:03 PDT 
Committed r292441 (249294@main): <https://commits.webkit.org/249294@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456761 [details].