RESOLVED FIXED 238814
[WebAuthn] Support all CTAP transports and remove gesture requirement for virtual authenticators 
https://bugs.webkit.org/show_bug.cgi?id=238814
Summary [WebAuthn] Support all CTAP transports and remove gesture requirement for vir...
pascoe@apple.com
Reported 2022-04-05 10:03:57 PDT
The user gesture prompt causes wpt tests to hang. We already support CTAP virtual authenticators with transport=usb, this bug should add support for the nfc and ble transports.
Attachments
Patch (10.24 KB, patch)
2022-04-05 10:57 PDT, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.18 KB, patch)
2022-04-06 14:29 PDT, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-04-05 10:04:07 PDT
<rdar://problem/91300515>
pascoe@apple.com
Comment 2 2022-04-05 10:57:49 PDT
Created attachment 456724 [details] Patch
Brent Fulgham
Comment 3 2022-04-05 11:06:29 PDT
Comment on attachment 456724 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456724&action=review This seems fine as long as we don't mis-advertise support to relying parties. Can you confirm before landing, please? > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:67 > + ASSERT_UNUSED(addResult, addResult.isNewEntry); We do not support Ble devices at present -- does allowing this here cause us to mis-state our hardware feature support to actually relying parties (as opposed to the test infrastructure?)
pascoe@apple.com
Comment 4 2022-04-06 14:29:40 PDT
Created attachment 456859 [details] Patch for landing
EWS
Comment 5 2022-04-07 22:41:21 PDT
Committed r292593 (249426@main): <https://commits.webkit.org/249426@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456859 [details].
Note You need to log in before you can comment on or make changes to this bug.