RESOLVED FIXED 238804
Implement faster lookup of HTML tags in the HTML parser 
https://bugs.webkit.org/show_bug.cgi?id=238804
Summary Implement faster lookup of HTML tags in the HTML parser
Chris Dumez
Reported 2022-04-05 07:49:05 PDT
Implement faster lookup of HTML tags in the HTML parser.
Attachments
Patch (11.44 KB, patch)
2022-04-05 07:58 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Generated findHTMLTag() function to facilitate review (36.67 KB, text/plain)
2022-04-05 07:58 PDT, Chris Dumez 		no flags
Details
Patch (11.47 KB, patch)
2022-04-05 09:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-04-05 07:58:13 PDT
Created attachment 456699 [details] Patch
Chris Dumez
Comment 2 2022-04-05 07:58:52 PDT
Created attachment 456700 [details] Generated findHTMLTag() function to facilitate review
Chris Dumez
Comment 3 2022-04-05 09:29:41 PDT
Created attachment 456708 [details] Patch
Geoffrey Garen
Comment 4 2022-04-05 12:38:49 PDT
Comment on attachment 456708 [details] Patch r=me Something I said in Slack to Chris: We might get more efficient branching if we eliminate the initial switch on length (since it does not eliminate many possibilities) and/or reorder the branches to make more likely tags like "div" fewer branches.
Chris Dumez
Comment 5 2022-04-05 12:39:51 PDT
(In reply to Geoffrey Garen from comment #4) > Comment on attachment 456708 [details] > Patch > > r=me > > Something I said in Slack to Chris: We might get more efficient branching if > we eliminate the initial switch on length (since it does not eliminate many > possibilities) and/or reorder the branches to make more likely tags like > "div" fewer branches. Yes, I will look into this and follow-up if A/B testing comes back as a further progression.
EWS
Comment 6 2022-04-05 13:17:28 PDT
Committed r292417 (249280@main): <https://commits.webkit.org/249280@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456708 [details].
Radar WebKit Bug Importer
Comment 7 2022-04-05 13:18:18 PDT
<rdar://problem/91311691>
Note You need to log in before you can comment on or make changes to this bug.