Bug 238804 - Implement faster lookup of HTML tags in the HTML parser
Summary: Implement faster lookup of HTML tags in the HTML parser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-05 07:49 PDT by Chris Dumez
Modified: 2022-04-05 13:18 PDT (History)
9 users (show)

See Also:

Attachments
Patch (11.44 KB, patch)
2022-04-05 07:58 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Generated findHTMLTag() function to facilitate review (36.67 KB, text/plain)
2022-04-05 07:58 PDT, Chris Dumez 		no flags Details
Patch (11.47 KB, patch)
2022-04-05 09:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-04-05 07:49:05 PDT 
Implement faster lookup of HTML tags in the HTML parser.
Comment 1 Chris Dumez 2022-04-05 07:58:13 PDT 
Created attachment 456699 [details]
Patch
Comment 2 Chris Dumez 2022-04-05 07:58:52 PDT 
Created attachment 456700 [details]
Generated findHTMLTag() function to facilitate review
Comment 3 Chris Dumez 2022-04-05 09:29:41 PDT 
Created attachment 456708 [details]
Patch
Comment 4 Geoffrey Garen 2022-04-05 12:38:49 PDT 
Comment on attachment 456708 [details]
Patch

r=me

Something I said in Slack to Chris: We might get more efficient branching if we eliminate the initial switch on length (since it does not eliminate many possibilities) and/or reorder the branches to make more likely tags like "div" fewer branches.
Comment 5 Chris Dumez 2022-04-05 12:39:51 PDT 
(In reply to Geoffrey Garen from comment #4)
> Comment on attachment 456708 [details]
> Patch
> 
> r=me
> 
> Something I said in Slack to Chris: We might get more efficient branching if
> we eliminate the initial switch on length (since it does not eliminate many
> possibilities) and/or reorder the branches to make more likely tags like
> "div" fewer branches.

Yes, I will look into this and follow-up if A/B testing comes back as a further progression.
Comment 6 EWS 2022-04-05 13:17:28 PDT 
Committed r292417 (249280@main): <https://commits.webkit.org/249280@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456708 [details].
Comment 7 Radar WebKit Bug Importer 2022-04-05 13:18:18 PDT 
<rdar://problem/91311691>