RESOLVED FIXED 23877
Allow port to disable progress events from media elements 
https://bugs.webkit.org/show_bug.cgi?id=23877
Summary Allow port to disable progress events from media elements
Eric Carlson
Reported 2009-02-10 13:35:00 PST
Not all media engines provide enough information about a file to be able to support progress events, so a port should be able to disable them completely instead of emitting invalid events.
Attachments
Proposed patch (3.61 KB, patch)
2009-02-10 14:42 PST, Eric Carlson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2009-02-10 14:42:04 PST
Created attachment 27541 [details] Proposed patch
Simon Fraser (smfr)
Comment 2 2009-02-10 15:24:10 PST
Comment on attachment 27541 [details] Proposed patch > Index: WebCore/html/HTMLMediaElement.h > =================================================================== > --- WebCore/html/HTMLMediaElement.h (revision 40828) > +++ WebCore/html/HTMLMediaElement.h (working copy) > @@ -221,6 +221,8 @@ protected: > OwnPtr<MediaPlayer> m_player; > > LoadRestrictions m_loadRestrictions; > + > + bool m_supportProgressEvents; Rename to something like 'm_sendProgressEvents' and add a comment about why you need the switch, and r=me.
Eric Carlson
Comment 3 2009-02-12 06:36:54 PST
Committed as r40857
Note You need to log in before you can comment on or make changes to this bug.