I noticed that the current 'features.json' file is out of date. I think the attached changes more accurately reflect the state of the engine.
Created attachment 456588 [details] Patch
Comment on attachment 456588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456588&action=review > Source/WebCore/features.json:1724 > - "enabled-by-default": false > + "enabled-by-default": true I would just remove this `"enabled-by-default"` line.
Comment on attachment 456588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456588&action=review >> Source/WebCore/features.json:1724 >> + "enabled-by-default": true > > I would just remove this `"enabled-by-default"` line. Will do!
Comment on attachment 456588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456588&action=review > Source/WebCore/features.json:182 > + "description": "The Custom Highlight API extends the concept of highlight pseudo-elements (see CSS Pseudo-Elements 4 § 3 Highlight Pseudo-elements) by providing a way for web developers to style the text of arbitrary Range objects, rather than being limited to the user agent defined ::selection, ::inactive-selection, ::spelling-error, and '::grammar-error'." Not sure why ::grammar-error has single quotes. > Source/WebCore/features.json:248 > + "description": "This specification defines a set of CSS properties that allow authors to specify a path. The object can be positioned, transitioned and animated along this path over a given period of time. The time may be static if no animation was specified." specify a path -> specify position along a path. Remove "The time may be static if no animation was specified." > Source/WebCore/features.json:253 > + "status": "In Development" Supported > Source/WebCore/features.json:257 > + "description": "A content author does not necessarily want scroll chaining to occur for all scroll containers. Some scroll containers may be part of a containing block chain but may serve a different logical purpose in the document and may want to prevent scrolling from continuing up the scroll chain. The overscroll-behavior property allows content authors to control scroll chaining and overscroll in a robust, performant and forward compatible way." I would just say: "Allow authors to control whether scrolling results in overscroll ("rubber-banding") and propagates to enclosing scroll containers." > Source/WebCore/features.json:880 > + "status": "Supported" Do we support the SpeechRecognition part of this? I don't think so, so In Development.
Comment on attachment 456588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456588&action=review >> Source/WebCore/features.json:182 >> + "description": "The Custom Highlight API extends the concept of highlight pseudo-elements (see CSS Pseudo-Elements 4 § 3 Highlight Pseudo-elements) by providing a way for web developers to style the text of arbitrary Range objects, rather than being limited to the user agent defined ::selection, ::inactive-selection, ::spelling-error, and '::grammar-error'." > > Not sure why ::grammar-error has single quotes. Fixed. >> Source/WebCore/features.json:248 >> + "description": "This specification defines a set of CSS properties that allow authors to specify a path. The object can be positioned, transitioned and animated along this path over a given period of time. The time may be static if no animation was specified." > > specify a path -> specify position along a path. Remove "The time may be static if no animation was specified." Fixed. >> Source/WebCore/features.json:253 >> + "status": "In Development" > > Supported Fixed. >> Source/WebCore/features.json:257 >> + "description": "A content author does not necessarily want scroll chaining to occur for all scroll containers. Some scroll containers may be part of a containing block chain but may serve a different logical purpose in the document and may want to prevent scrolling from continuing up the scroll chain. The overscroll-behavior property allows content authors to control scroll chaining and overscroll in a robust, performant and forward compatible way." > > I would just say: > "Allow authors to control whether scrolling results in overscroll ("rubber-banding") and propagates to enclosing scroll containers." Fixed. >> Source/WebCore/features.json:880 >> + "status": "Supported" > > Do we support the SpeechRecognition part of this? I don't think so, so In Development. We do! That was a big part of our Safari feature work for iOS 14 and Big Sur.
Created attachment 456595 [details] Patch for landing
Committed r292311 (249204@main): <https://commits.webkit.org/249204@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456595 [details].
<rdar://problem/91256246>