Bug 238736 – Simplify / Optimize the whitespace cache implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Simplify / Optimize the whitespace cache implementation.

[Chris Dumez]

Created attachment 456568 [details]
Patch

[Sam Weinig]

Comment on attachment 456568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456568&action=review

> Source/WebCore/html/parser/HTMLConstructionSite.h:245
> +    WhitespaceCache() :
> +        m_atoms(maximumCachedStringLength)
> +    { }

Unconventional style. Probably this:

WhitespaceCache()
    : m_atoms(maximumCachedStringLength)
{
}

[Chris Dumez]

(In reply to Sam Weinig from comment #2)
> Comment on attachment 456568 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456568&action=review
> 
> > Source/WebCore/html/parser/HTMLConstructionSite.h:245
> > +    WhitespaceCache() :
> > +        m_atoms(maximumCachedStringLength)
> > +    { }
> 
> Unconventional style. Probably this:
> 
> WhitespaceCache()
>     : m_atoms(maximumCachedStringLength)
> {
> }

Ooops, my bad, not sure what happened there.

[Chris Dumez]

Created attachment 456584 [details]
Patch

[EWS]

Committed r292310 (249203@main): <https://commits.webkit.org/249203@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456584 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91255370>

[Darin Adler]

Comment on attachment 456584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456584&action=review

> Source/WebCore/html/parser/HTMLConstructionSite.h:52
> +namespace WebCore {
>  struct HTMLConstructionSiteTask {

Missing space here.

[Chris Dumez]

Comment on attachment 456584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456584&action=review

>> Source/WebCore/html/parser/HTMLConstructionSite.h:52
>>  struct HTMLConstructionSiteTask {
> 
> Missing space here.

I can add a blank line between the namespace and the struct, assuming that's what you mean.

[Chris Dumez]

Reopening to attach new patch.

[Chris Dumez]

Created attachment 457121 [details]
Follow-up to fix style

[Darin Adler]

Comment on attachment 457121 [details]
Follow-up to fix style

View in context: https://bugs.webkit.org/attachment.cgi?id=457121&action=review

> Source/WebCore/html/parser/HTMLConstructionSite.h:52
>  namespace WTF {
> +
>  template<> struct VectorTraits<WebCore::AtomStringWithCode> : SimpleClassVectorTraits { };
> +
>  }

Not sure we needed these, but the others do seem important to look right.

[Chris Dumez]

Committed r292638 (249458@trunk): <https://commits.webkit.org/249458@trunk>