Bug 238733 - [GTK][WPE] Use UnixFileDescriptor in DMABufObject, DMABufReleaseFlag
Summary: [GTK][WPE] Use UnixFileDescriptor in DMABufObject, DMABufReleaseFlag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on: 238726
Blocks:
  Show dependency tree / graph
 
Reported: 2022-04-04 05:52 PDT by Zan Dobersek
Modified: 2022-04-05 04:30 PDT (History)
3 users (show)

See Also:

Attachments
Pending changes (8.41 KB, patch)
2022-04-04 05:52 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (11.09 KB, patch)
2022-04-04 08:46 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (11.24 KB, patch)
2022-04-05 04:16 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2022-04-04 05:52:02 PDT 
Once it's there, it's usable.
Comment 1 Zan Dobersek 2022-04-04 05:52:47 PDT 
Created attachment 456563 [details]
Pending changes

Waiting on bug #238726.
Comment 2 Zan Dobersek 2022-04-04 08:46:44 PDT 
Created attachment 456573 [details]
Patch

Won't build, but it's functional as soon as the dependent bug lands, so already reviewable.
Comment 3 Adrian Perez 2022-04-04 14:22:21 PDT 
Comment on attachment 456573 [details]
Patch

Very nice simplifications 🛠️
Comment 4 Zan Dobersek (Reviews) 2022-04-04 23:54:49 PDT 
Comment on attachment 456573 [details]
Patch

Clearing flags on attachment: 456573

Committed r292377 (249242@trunk): <https://commits.webkit.org/249242@trunk>
Comment 5 Zan Dobersek (Reviews) 2022-04-04 23:54:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2022-04-04 23:55:17 PDT 
<rdar://problem/91280204>
Comment 7 Zan Dobersek (Reviews) 2022-04-05 00:32:46 PDT 
Reverted r292377 for reason:

The depended-on patch hasn't landed yet

Committed r292380 (249245@trunk): <https://commits.webkit.org/249245@trunk>
Comment 8 Zan Dobersek 2022-04-05 04:16:42 PDT 
Created attachment 456691 [details]
Patch for landing

Adjusted after further changes in bug #238726.
Comment 9 Zan Dobersek (Reviews) 2022-04-05 04:30:22 PDT 
Comment on attachment 456691 [details]
Patch for landing

Clearing flags on attachment: 456691

Committed r292391 (249256@trunk): <https://commits.webkit.org/249256@trunk>
Comment 10 Zan Dobersek (Reviews) 2022-04-05 04:30:28 PDT 
All reviewed patches have been landed.  Closing bug.