RESOLVED FIXED Bug 238701
Start replacing String(const char*) constructor with a String::fromLatin1(const char*) function 
https://bugs.webkit.org/show_bug.cgi?id=238701
Summary Start replacing String(const char*) constructor with a String::fromLatin1(con...
Chris Dumez
Reported 2022-04-02 12:58:12 PDT
Replace String(const char*) constructor with a String::fromLatin1(const char*) function. It is more consistent with String::fromUTF8() and makes it clearer that input is treated as Latin-1.
Attachments
Patch (95.69 KB, patch)
2022-04-05 20:28 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (94.94 KB, patch)
2022-04-05 21:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-04-05 20:28:44 PDT
Created attachment 456777 [details] Patch
Chris Dumez
Comment 2 2022-04-05 21:44:41 PDT
Created attachment 456782 [details] Patch
Geoffrey Garen
Comment 3 2022-04-06 10:53:24 PDT
Comment on attachment 456782 [details] Patch r=me
Chris Dumez
Comment 4 2022-04-06 12:05:36 PDT
Comment on attachment 456782 [details] Patch Clearing flags on attachment: 456782 Committed r292487 (?): <https://commits.webkit.org/r292487>
Chris Dumez
Comment 5 2022-04-06 12:05:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2022-04-06 12:06:18 PDT
<rdar://problem/91368828>
Note You need to log in before you can comment on or make changes to this bug.