Bug 238687 – [iOS] Several tests in media/modern-media-controls crash in -[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Wenson Hsieh]

These are the ones I reproduced locally (basically the ones that present the media controls context menu):

media/modern-media-controls/overflow-support/button-state.html
media/modern-media-controls/overflow-support/chapters.html
media/modern-media-controls/overflow-support/playback-speed.html
media/modern-media-controls/tracks-support/audio-multiple-tracks.html
media/modern-media-controls/tracks-support/audio-single-track.html
media/modern-media-controls/tracks-support/auto-text-track.html
media/modern-media-controls/tracks-support/click-track-in-contextmenu.html
media/modern-media-controls/tracks-support/hidden-tracks.html
media/modern-media-controls/tracks-support/off-text-track.html

```
Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   WebKit                        	       0x151e56c8c WTF::RefPtr<WTF::StringImpl, WTF::RawPtrTraits<WTF::StringImpl>, WTF::DefaultRefDerefTraits<WTF::StringImpl> >::operator!() const + 12
1   WebKit                        	       0x151ea3689 WTF::String::isEmpty() const + 25
2   WebKit                        	       0x15357f693 -[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]::$_4::operator()(WebCore::MediaControlsContextMenuItem&) const + 51
3   WebKit                        	       0x15357f64d decltype(static_cast<-[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]::$_4>(fp)(static_cast<WebCore::MediaControlsContextMenuItem&>(fp0))) std::__1::__invoke<-[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]::$_4, WebCore::MediaControlsContextMenuItem&>(-[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]::$_4&&, WebCore::MediaControlsContextMenuItem&) + 29
4   WebKit                        	       0x15357f5c2 std::__1::invoke_result<-[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]::$_4, WebCore::MediaControlsContextMenuItem&>::type std::__1::invoke<-[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]::$_4, WebCore::MediaControlsContextMenuItem&>(-[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]::$_4&&, WebCore::MediaControlsContextMenuItem&) + 50
5   WebKit                        	       0x1535717be WTF::RetainPtr<NSMutableArray> WTF::createNSArray<WTF::Vector<WebCore::MediaControlsContextMenuItem, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, -[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]::$_4>(WTF::Vector<WebCore::MediaControlsContextMenuItem, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, -[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:]::$_4&&) + 238
6   WebKit                        	       0x153571681 -[WKActionSheetAssistant _uiMenuElementsForMediaControlContextMenuItems:] + 49
7   WebKit                        	       0x153571b89 -[WKActionSheetAssistant showMediaControlsContextMenu:items:completionHandler:] + 809
8   WebKit                        	       0x1549d4d15 -[WKContentView(WKInteraction) _showMediaControlsContextMenu:items:completionHandler:] + 117
```

[Wenson Hsieh]

The `WTFMove(item.icon)` is unsafe, I think.. Just need to avoid that

[Wenson Hsieh]

Created attachment 456424 [details]
Patch

[Tim Horton]

Comment on attachment 456424 [details]
Patch

Oof

[Wenson Hsieh]

Comment on attachment 456424 [details]
Patch

Thanks for the review!

(In reply to Tim Horton from comment #3)
> Comment on attachment 456424 [details]
> Patch
> 
> Oof

...indeed :P

[EWS]

Committed r292260 (249158@main): <https://commits.webkit.org/249158@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456424 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91196038>