Bug 238685 – [GStreamer] gst_video_format_info_component not defined in GStreamer <1.18

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Diego Pino]

[GStreamer] gst_video_format_info_component not defined in GStreamer <1.18

[Diego Pino]

Created attachment 456416 [details]
Patch

[Philippe Normand]

Comment on attachment 456416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456416&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-33
> +#if USE(GSTREAMER)
> +#include "GStreamerCommon.h"
> +#endif
> +
>  #if ENABLE(VIDEO) && USE(GSTREAMER)
>  
>  #include "GraphicsContext.h"
>  #include "GStreamerAudioMixer.h"
> -#include "GStreamerCommon.h"

Why is this change needed?

[Xabier Rodríguez Calvar]

Comment on attachment 456416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456416&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:93
> +    /* Reverse mapping of info->plane */

. at the end as per coding style.

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-33
>> -#include "GStreamerCommon.h"
> 
> Why is this change needed?

Please, do not remove this.

[Diego Pino]

Created attachment 456574 [details]
Patch

[Philippe Normand]

Comment on attachment 456574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456574&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

You can remove this and then we're good to go!

[Diego Pino]

Created attachment 456679 [details]
Patch

[Diego Pino]

(In reply to Philippe Normand from comment #2)
> Comment on attachment 456416 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456416&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-33
> > +#if USE(GSTREAMER)
> > +#include "GStreamerCommon.h"
> > +#endif
> > +
> >  #if ENABLE(VIDEO) && USE(GSTREAMER)
> >  
> >  #include "GraphicsContext.h"
> >  #include "GStreamerAudioMixer.h"
> > -#include "GStreamerCommon.h"
> 
> Why is this change needed?

The reason why I initially introduced this change was because at some point I got a link problem. The linker could not resolve the symbol `webkitGstVideoFormatInfoComponent`. I implemented this change and got the link error solved. However, after the feedback, I undid the change and build from scratch WebKitGTK/WPE and got no link error, so it seemed this change was not needed.

[EWS]

Committed r292387 (249252@main): <https://commits.webkit.org/249252@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456679 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91283863>