Bug 23868 - Add HTMLInputElement, HTMLOptionsCollection V8 custom bindings
Summary: Add HTMLInputElement, HTMLOptionsCollection V8 custom bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-10 09:21 PST by Dimitri Glazkov (Google)
Modified: 2009-02-10 13:48 PST (History)
0 users

See Also:


Attachments
Add HTMLInputElement and HTMLOptionsCollection V8 custom bindings (8.60 KB, patch)
2009-02-10 09:23 PST, Dimitri Glazkov (Google)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-02-10 09:21:41 PST
Two more custom bindings files, pre-scrubbed.
Comment 1 Dimitri Glazkov (Google) 2009-02-10 09:23:31 PST
Created attachment 27520 [details]
Add HTMLInputElement and HTMLOptionsCollection V8 custom bindings

 WebCore/ChangeLog                                  |   15 +++
 .../v8/custom/V8HTMLInputElementCustom.cpp         |  124 ++++++++++++++++++++
 .../v8/custom/V8HTMLOptionsCollectionCustom.cpp    |   75 ++++++++++++
 3 files changed, 214 insertions(+), 0 deletions(-)
Comment 2 Eric Seidel (no email) 2009-02-10 13:35:51 PST
Comment on attachment 27520 [details]
Add HTMLInputElement and HTMLOptionsCollection V8 custom bindings

A couple style issues:

 62     if (!isnan(v) && !isinf(v)) {
 63         if (v < 0.0) {
 64             ec = INDEX_SIZE_ERR;
 65         } else if (v > static_cast<double>(UINT_MAX)) {
 66             newLength = UINT_MAX;
 67         } else {
 68             newLength = static_cast<unsigned>(v);
 69         }
 70     }
 71     if (!ec) imp->setLength(value->Uint32Value(), ec);

Otherwise looks great.

We need to find a better name for V8Proxy.
Comment 3 Dimitri Glazkov (Google) 2009-02-10 13:48:12 PST
Landed as http://trac.webkit.org/changeset/40833