Bug 238672 – Sharing services picker menu Mail presents in the wrong place when compose web view is scrolled

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kate Cheney]

Sharing services picker menu Mail presents in the wrong place when compose web view is scrolled

[Kate Cheney]

Created attachment 456373 [details]
Patch

[Kate Cheney]

rdar://88966924

[Wenson Hsieh]

Comment on attachment 456373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456373&action=review

> Source/WebCore/dom/mac/ImageControlsMac.cpp:149
> +        ContextMenuController& controller = page->contextMenuController();

Minor nit - I think we prefer `auto&` here.

> Source/WebCore/dom/mac/ImageControlsMac.cpp:150
> +        Frame* frame = controller.hitTestResult().innerNodeFrame();

I think it would be safer to use RefPtr here, since it's possible for `WebPage::handleImageServiceClick` to trigger a style update.

> Source/WebCore/dom/mac/ImageControlsMac.cpp:154
> +        FrameView* view = frame->view();

(Ditto)

[Kate Cheney]

Created attachment 457095 [details]
Patch

[Wenson Hsieh]

Comment on attachment 457095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457095&action=review

> Source/WebCore/dom/mac/ImageControlsMac.cpp:149
> +        auto& element = downcast<Element>(node);

Let's use RefPtr here.

> Source/WebCore/dom/mac/ImageControlsMac.cpp:159
> +        auto rect = view->convertToContainingWindow(renderer->absoluteBoundingBoxRect());
> +        auto point = view->contentsToWindow(rect).minXMaxYCorner();

This seems kind of strange to me (I'm pretty sure the return value of `convertToContainingWindow` isn't also in absolute/content coordinates?)

[Wenson Hsieh]

Comment on attachment 457095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457095&action=review

>> Source/WebCore/dom/mac/ImageControlsMac.cpp:149
>> +        auto& element = downcast<Element>(node);
> 
> Let's use RefPtr here.

(Ref, sorry!)

[Kate Cheney]

Created attachment 457108 [details]
Patch

[Kate Cheney]

thanks for the review!

[EWS]

Committed r292676 (249468@main): <https://commits.webkit.org/249468@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457108 [details].