Bug 23867 - Eliminate obsolete frame->document() checks
Summary: Eliminate obsolete frame->document() checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-10 08:04 PST by Alexey Proskuryakov
Modified: 2009-02-10 09:33 PST (History)
0 users

See Also:


Attachments
proposed patch (73.04 KB, patch)
2009-02-10 08:18 PST, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-02-10 08:04:38 PST
Every frame always has a document now (except construction/teardown time). Most checks for document being non-null come from earlier times, when this wasn't the case.
Comment 1 Alexey Proskuryakov 2009-02-10 08:18:58 PST
Created attachment 27519 [details]
proposed patch
Comment 2 Darin Adler 2009-02-10 08:55:54 PST
Comment on attachment 27519 [details]
proposed patch

Should Frame::document() also assert that it's non-zero? I guess that's not critical since it will probably crash a moment later when the document pointer is used.

r=me
Comment 3 Alexey Proskuryakov 2009-02-10 09:33:52 PST
Committed revision 40824.