WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23867
Eliminate obsolete frame->document() checks
https://bugs.webkit.org/show_bug.cgi?id=23867
Summary
Eliminate obsolete frame->document() checks
Alexey Proskuryakov
Reported
2009-02-10 08:04:38 PST
Every frame always has a document now (except construction/teardown time). Most checks for document being non-null come from earlier times, when this wasn't the case.
Attachments
proposed patch
(73.04 KB, patch)
2009-02-10 08:18 PST
,
Alexey Proskuryakov
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2009-02-10 08:18:58 PST
Created
attachment 27519
[details]
proposed patch
Darin Adler
Comment 2
2009-02-10 08:55:54 PST
Comment on
attachment 27519
[details]
proposed patch Should Frame::document() also assert that it's non-zero? I guess that's not critical since it will probably crash a moment later when the document pointer is used. r=me
Alexey Proskuryakov
Comment 3
2009-02-10 09:33:52 PST
Committed revision 40824.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug