Bug 238669 - GTK doesn't compile with ENABLE_ACCESSIBILITY=0
Summary: GTK doesn't compile with ENABLE_ACCESSIBILITY=0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
: 239837 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-04-01 10:00 PDT by Yury Semikhatsky
Modified: 2022-04-28 08:17 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.37 KB, patch)
2022-04-01 10:02 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2022-04-01 10:00:52 PDT
GTK doesn't compile with ENABLE_ACCESSIBILITY=0
Comment 1 Yury Semikhatsky 2022-04-01 10:02:27 PDT
Created attachment 456369 [details]
Patch
Comment 2 Yury Semikhatsky 2022-04-01 10:05:14 PDT
The error it is fixing is:

../../../Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:697:43: error: use of undeclared identifier 'WEBKIT_WEB_VIEW_ACCESSIBLE'                                                                                                                                           
        webkitWebViewAccessibleSetWebView(WEBKIT_WEB_VIEW_ACCESSIBLE(webView->priv->accessible.get()), nullptr);                                                                                                                                                                  
                                          ^                                                                                                                                                                                                                                       
../../../Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1694:49: error: use of undeclared identifier 'webkitWebViewAccessibleNew'                                                                                                                                          
        priv->accessible = adoptGRef(ATK_OBJECT(webkitWebViewAccessibleNew(widget)));                                                                                                                                                                                             
                                                ^                                                                                                                                                                                                                                 
2 errors generated.
Comment 3 EWS 2022-04-02 09:00:16 PDT
Committed r292265 (249163@main): <https://commits.webkit.org/249163@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456369 [details].
Comment 4 Michael Catanzaro 2022-04-28 08:17:07 PDT
*** Bug 239837 has been marked as a duplicate of this bug. ***