Bug 238652 - update-angle script doesn't regenerate changes.diff properly
Summary: update-angle script doesn't regenerate changes.diff properly
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-31 20:28 PDT by Kenneth Russell
Modified: 2022-04-07 20:29 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2022-03-31 20:28:24 PDT 
The update-angle script pauses at its end waiting for the build to be fixed, and regenerates changes.diff afterward.

I'm pretty sure something is wrong with the way changes.diff is regenerated. Even if local changes are made to files at this point (e.g. eliminating unnecessary whitespace changes), the final changes.diff doesn't reflect them.

Filing this so this doesn't get lost.
Comment 1 Radar WebKit Bug Importer 2022-04-07 20:29:13 PDT 
<rdar://problem/91460750>