Bug 23862 - When interrupting accelerated animations, need to simulate style differences
Summary: When interrupting accelerated animations, need to simulate style differences
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 23359
  Show dependency treegraph
 
Reported: 2009-02-09 18:13 PST by Simon Fraser (smfr)
Modified: 2009-02-11 15:19 PST (History)
1 user (show)

See Also:


Attachments
Patch, changelog (7.10 KB, patch)
2009-02-11 13:23 PST, Simon Fraser (smfr)
hyatt: review-
Details | Formatted Diff | Diff
Updated patch (6.28 KB, patch)
2009-02-11 15:10 PST, Simon Fraser (smfr)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-02-09 18:13:37 PST
When accelerated animations are running, the softare animation timer is not firing, and we are not constantly changing the RenderStyles (because the animation is being run by the compositing system). This gives great performance, but forces the need to special-case some instances where we compare RenderStyels to know if things are changing.
Comment 1 Simon Fraser (smfr) 2009-02-11 13:23:38 PST
Created attachment 27570 [details]
Patch, changelog
Comment 2 Simon Fraser (smfr) 2009-02-11 13:25:02 PST
I'll fix the "as a child using inheriting the transform" comment before checkin.
Comment 3 Dave Hyatt 2009-02-11 13:37:08 PST
Comment on attachment 27570 [details]
Patch, changelog

Typo:

"propery" should be "property"

Why two bits?  It seems like a single flag is good enough, especially given they are both in the same struct.  We can revisit if more bits end up in different structs, but for now I'd just do one.
Comment 4 Simon Fraser (smfr) 2009-02-11 15:10:24 PST
Created attachment 27574 [details]
Updated patch
Comment 5 Dave Hyatt 2009-02-11 15:13:21 PST
Comment on attachment 27574 [details]
Updated patch

r=me
Comment 6 Simon Fraser (smfr) 2009-02-11 15:19:10 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/page/animation/ImplicitAnimation.cpp
	M	WebCore/rendering/style/RenderStyle.h
	M	WebCore/rendering/style/StyleRareNonInheritedData.cpp
	M	WebCore/rendering/style/StyleRareNonInheritedData.h
Committed r40876