Bug 238591 - Add more push-related logging
Summary: Add more push-related logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-30 22:13 PDT by Ben Nham
Modified: 2022-04-01 13:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (12.04 KB, patch)
2022-03-30 22:36 PDT, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch (23.21 KB, patch)
2022-03-31 11:20 PDT, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch (26.14 KB, patch)
2022-03-31 20:20 PDT, Ben Nham 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2022-03-30 22:13:04 PDT 
Add more push-related logging
Comment 1 Ben Nham 2022-03-30 22:32:19 PDT 
rdar://91067124
Comment 2 Ben Nham 2022-03-30 22:36:29 PDT 
Created attachment 456204 [details]
Patch
Comment 3 youenn fablet 2022-03-31 06:44:15 PDT 
Comment on attachment 456204 [details]
Patch

r=me once bots are happy.

View in context: https://bugs.webkit.org/attachment.cgi?id=456204&action=review

> Source/WebCore/Modules/push-api/PushManager.cpp:143
> +                RELEASE_LOG(Push, "Failing PushManager.subscribe call due to failed transient activation check; last activated %.2f sec ago", lastActivationDuration.value());

RELEASE_LOG_ERROR

> Source/WebCore/workers/service/server/SWServer.cpp:1287
> +            RELEASE_LOG(Push, "Cannot process push message: Failed to find SW registration for registration key %s", registrationKey.loggingString().utf8().data());

RELEASE_LOG_ERROR

> Source/WebCore/workers/service/server/SWServer.cpp:1294
> +            RELEASE_LOG(Push, "Cannot process push message: No active worker for registration key %s", registrationKey.loggingString().utf8().data());

RELEASE_LOG_ERROR

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2305
> +        RELEASE_LOG(Push, "NetworkProcess getting pending push messages for session ID %" PRIu64, sessionID.toUInt64());

Is this one really useful?

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2310
> +    RELEASE_LOG_ERROR(Push, "NetworkProcess could not find session for ID %llu to get pending push messages", sessionID.toUInt64());

Ditto.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2332
> +    RELEASE_LOG_ERROR(Push, "Networking process asked to handle a push message from UI process in session %llu, but that session doesn't exist", sessionID.toUInt64());

We generally do not release log missing session errors.
Comment 4 Ben Nham 2022-03-31 11:20:24 PDT 
Created attachment 456258 [details]
Patch
Comment 5 Ben Nham 2022-03-31 20:20:57 PDT 
Created attachment 456314 [details]
Patch
Comment 6 EWS 2022-04-01 13:48:55 PDT 
Committed r292232 (249134@main): <https://commits.webkit.org/249134@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456314 [details].