Bug 238566 - Add to MiniBrowser the ability to log a textual representation of the AX trees for the current page.
Summary: Add to MiniBrowser the ability to log a textual representation of the AX tree...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-30 12:12 PDT by Andres Gonzalez
Modified: 2022-04-02 14:54 PDT (History)
4 users (show)

See Also:


Attachments
Patch (7.81 KB, patch)
2022-03-30 12:19 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff
Patch (7.78 KB, patch)
2022-04-02 07:47 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff
Patch (7.78 KB, patch)
2022-04-02 11:57 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff
Patch (7.80 KB, patch)
2022-04-02 12:09 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2022-03-30 12:12:41 PDT
Add to MiniBrowser the ability to log a textual representation of the AX trees for the current page.
Comment 1 Radar WebKit Bug Importer 2022-03-30 12:12:53 PDT
<rdar://problem/91059308>
Comment 2 Andres Gonzalez 2022-03-30 12:19:07 PDT
Created attachment 456162 [details]
Patch
Comment 3 chris fleizach 2022-03-30 13:05:43 PDT
Comment on attachment 456162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456162&action=review

> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:312
> +#pragma clang diagnostic push

are you sure this is deprecated? I don't see it
Comment 4 Andres Gonzalez 2022-04-02 07:47:21 PDT
Created attachment 456456 [details]
Patch
Comment 5 Andres Gonzalez 2022-04-02 10:06:50 PDT
(In reply to chris fleizach from comment #3)
> Comment on attachment 456162 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456162&action=review
> 
> > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:312
> > +#pragma clang diagnostic push
> 
> are you sure this is deprecated? I don't see it

The same thing is done for Save As PDF and WebArchive, so I'm assuming it is needed.
Comment 6 Simon Fraser (smfr) 2022-04-02 10:18:59 PDT
Comment on attachment 456456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456456&action=review

Consider doing this via `notifyutil` instead.

> Tools/MiniBrowser/mac/MainMenu.xib:784
> +                            <menuItem title="Log Accessibility Trees" keyEquivalent="a" id="540">

This is called "log" but throws up a save panel, which is odd. It should also have a ... after the name if it throws a panel.
Comment 7 Andres Gonzalez 2022-04-02 11:57:56 PDT
Created attachment 456463 [details]
Patch
Comment 8 Andres Gonzalez 2022-04-02 12:00:49 PDT
(In reply to Simon Fraser (smfr) from comment #6)
> Comment on attachment 456456 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456456&action=review
> 
> Consider doing this via `notifyutil` instead.

Thanks, will look into that separately.
> 
> > Tools/MiniBrowser/mac/MainMenu.xib:784
> > +                            <menuItem title="Log Accessibility Trees" keyEquivalent="a" id="540">
> 
> This is called "log" but throws up a save panel, which is odd. It should
> also have a ... after the name if it throws a panel.

Fixed, thanks.
Comment 9 Andres Gonzalez 2022-04-02 12:09:18 PDT
Created attachment 456465 [details]
Patch
Comment 10 EWS 2022-04-02 14:54:10 PDT
Committed r292271 (249169@main): <https://commits.webkit.org/249169@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456465 [details].