Bug 238562 – CSP: WASM fails to execute after window.open

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kate Cheney]

CSP: WASM fails to execute after window.open

[Kate Cheney]

Created attachment 456158 [details]
Patch

[Kate Cheney]

rdar://90778752

[Kate Cheney]

Created attachment 456240 [details]
Patch

[Brent Fulgham]

Comment on attachment 456240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456240&action=review

r=me. It's a shame we don't have WPT that cover this, too.

> Source/WebCore/bindings/js/ScriptController.cpp:414
> +    jsWindowProxy->window()->setEvalEnabled(value, errorMessage);

Nit: Not relevant for your patch, but I wonder if saving the identical string in every AbstractDOMWindow is good, since there is only one string used for either case (rather than a bunch of unique strings tailored to the window.

[Kate Cheney]

(In reply to Brent Fulgham from comment #4)
> Comment on attachment 456240 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456240&action=review
> 
> r=me. It's a shame we don't have WPT that cover this, too.
> 

Thanks for the review!

> > Source/WebCore/bindings/js/ScriptController.cpp:414
> > +    jsWindowProxy->window()->setEvalEnabled(value, errorMessage);
> 
> Nit: Not relevant for your patch, but I wonder if saving the identical
> string in every AbstractDOMWindow is good, since there is only one string
> used for either case (rather than a bunch of unique strings tailored to the
> window.

True, filed rdar://91169940.

[Kate Cheney]

Created attachment 456371 [details]
[fast-cq] Patch for landing

[EWS]

Committed r292229 (249131@main): <https://commits.webkit.org/249131@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456371 [details].