Bug 238552 - Optimize the construction of a JSC::Identifier from an ASCIILiteral
Summary: Optimize the construction of a JSC::Identifier from an ASCIILiteral
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 238574
  Show dependency tree / graph
 
Reported: 2022-03-30 07:09 PDT by Chris Dumez
Modified: 2022-03-30 14:02 PDT (History)
22 users (show)

See Also:

Attachments
Patch (357.77 KB, patch)
2022-03-30 07:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (357.77 KB, patch)
2022-03-30 07:48 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-03-30 07:09:21 PDT 
Optimize the constructor of a JSC::Identifier from an ASCIILiteral, and adopt more broadly in our code base.
Comment 1 Chris Dumez 2022-03-30 07:30:33 PDT 
Created attachment 456120 [details]
Patch
Comment 2 Chris Dumez 2022-03-30 07:48:48 PDT 
Created attachment 456122 [details]
Patch
Comment 3 Geoffrey Garen 2022-03-30 13:30:11 PDT 
Comment on attachment 456122 [details]
Patch

r=me
Comment 4 Chris Dumez 2022-03-30 13:42:08 PDT 
Comment on attachment 456122 [details]
Patch

Clearing flags on attachment: 456122

Committed r292118 (249031@trunk): <https://commits.webkit.org/249031@trunk>
Comment 5 Chris Dumez 2022-03-30 13:42:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2022-03-30 13:43:19 PDT 
<rdar://problem/91064259>