Bug 238550 – Split streaming of AX trees from the class AXLogger.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

Split streaming of AX trees from the class AXLogger.

[Radar WebKit Bug Importer]

<rdar://problem/91041921>

[Andres Gonzalez]

Created attachment 456117 [details]
Patch

[Tyler Wilcock]

Comment on attachment 456117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456117&action=review

> Source/WebCore/accessibility/AXLogger.cpp:568
> +        stream.dumpProperty("roleValue", role);

I know this isn't new with your patch, but I wonder if it would be better to shorten this to role instead of roleValue to make the logs a little less noisy. I get that roleValue is the name of the method in AXCoreObject, but in this case I don't think it's necessary to include the full method name.

[Andres Gonzalez]

Created attachment 456137 [details]
Patch

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 456117 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456117&action=review
> 
> > Source/WebCore/accessibility/AXLogger.cpp:568
> > +        stream.dumpProperty("roleValue", role);
> 
> I know this isn't new with your patch, but I wonder if it would be better to
> shorten this to role instead of roleValue to make the logs a little less
> noisy. I get that roleValue is the name of the method in AXCoreObject, but
> in this case I don't think it's necessary to include the full method name.

Done.

[EWS]

Committed r292142 (249049@main): <https://commits.webkit.org/249049@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456137 [details].