Bug 238533 - Web Inspector: Sources: the mapped file URL of a Response Local Override should be clickable
Summary: Web Inspector: Sources: the mapped file URL of a Response Local Override shou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 238236
Blocks:
  Show dependency tree / graph
 
Reported: 2022-03-29 18:31 PDT by Devin Rousso
Modified: 2022-03-30 13:58 PDT (History)
6 users (show)

See Also:

Attachments
[fast-cq] Patch (23.50 KB, patch)
2022-03-29 18:34 PDT, Devin Rousso 		pangle: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
[fast-cq] Patch (23.76 KB, patch)
2022-03-30 09:53 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2022-03-29 18:31:32 PDT 
clicking it should either open the file in the default editor or reveal it in the system file explorer
Comment 1 Devin Rousso 2022-03-29 18:34:24 PDT 
Created attachment 456084 [details]
[fast-cq] Patch
Comment 2 Patrick Angle 2022-03-29 20:24:06 PDT 
Comment on attachment 456084 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456084&action=review

rs=me with one suggestion – also the build failures on GTK and others look real.

> Source/WebCore/ChangeLog:11
> +        (WebCore::InspectorFrontendHost::selectFileExternally): Added.

Just one overarching question throughout: can we consider naming this `revealFileExternally` (and changing all the other method names to match)? Perhaps that is too much Mac influence here, but in general I see this sort of action behind a "Reveal in [...]" menu item in apps. `select`, in my opinion, is somewhat ambiguous with showing a file chooser to let someone choose (or "select") a file.
Comment 3 Devin Rousso 2022-03-30 09:53:41 PDT 
Created attachment 456133 [details]
[fast-cq] Patch
Comment 4 EWS 2022-03-30 13:57:12 PDT 
Committed r292120 (249033@main): <https://commits.webkit.org/249033@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456133 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-30 13:58:17 PDT 
<rdar://problem/91065118>