Bug 238531 – Avoid initializing default WKWebsiteDataStore in -[WKWebViewConfiguration copyWithZone]

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Sihui Liu]

...

[Sihui Liu]

rdar://90628101

[Sihui Liu]

Created attachment 456090 [details]
Patch

[Sihui Liu]

Created attachment 456147 [details]
Patch for landing

[Sihui Liu]

Created attachment 456148 [details]
Patch for landing

[EWS]

Committed r292119 (249032@main): <https://commits.webkit.org/249032@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456148 [details].

[Truitt Savell]

The new API test TestWebKitAPI.WKWebsiteDataStore.DoNotCreateDefaultDataStore

added in https://github.com/WebKit/WebKit/commit/20c067e6fb466f9d4781e952f153092c9fc7e350

is a constant failure.

History:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WKWebsiteDataStore.DoNotCreateDefaultDataStore

log:
TestWebKitAPI.WKWebsiteDataStore.DoNotCreateDefaultDataStore
        
        /Volumes/Data/worker/monterey-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:420
        Value of: [WKWebsiteDataStore _defaultDataStoreExists]
          Actual: true
        Expected: false

[WebKit Commit Bot]

Re-opened since this is blocked by bug 238638

[Sihui Liu]

Created attachment 456402 [details]
Patch

[Robert Jenner]

I was able to reproduce locally, but I had to get creative since this was a newly introduced test, and since it was recently reverted there is of course no reproduction at ToT because the test was removed. Here are my steps: 

1. I downloaded Monterey Debug Build r292161 to test with. I chose that specific build because it was closer to the end in the range of revisions that this test failed on in the history. 

2. I was checked out to ToT, but just in the event that the test would not run, I reverted my checkout locally to r292161. I got the hashcode for that revision and did git checkout 6ddf72853c64be73426bce0a14fafa00690b3499

3. I ran the test as follows and was able to reproduce the failure: 

run-api-tests --debug TestWebKitAPI.WKWebsiteDataStore.DoNotCreateDefaultDataStore

[Sihui Liu]

Comment on attachment 456148 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=456148&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:385
>      configuration.websiteDataStore = self.websiteDataStore;

ah! I didn't remove this line when landing the patch... that's why it constantly failed on bots and constantly passes on my local build (my local build is correct)
The fact that Truitt can reproduce it so easily makes me realize that; thanks!

... I will just re-land the patch as it should be

[Sihui Liu]

(In reply to Robert Jenner from comment #9)
> I was able to reproduce locally, but I had to get creative since this was a
> newly introduced test, and since it was recently reverted there is of course
> no reproduction at ToT because the test was removed. Here are my steps: 
> 
> 1. I downloaded Monterey Debug Build r292161 to test with. I chose that
> specific build because it was closer to the end in the range of revisions
> that this test failed on in the history. 
> 
> 2. I was checked out to ToT, but just in the event that the test would not
> run, I reverted my checkout locally to r292161. I got the hashcode for that
> revision and did git checkout 6ddf72853c64be73426bce0a14fafa00690b3499
> 
> 3. I ran the test as follows and was able to reproduce the failure: 
> 
> run-api-tests --debug
> TestWebKitAPI.WKWebsiteDataStore.DoNotCreateDefaultDataStore

Thanks for the help, Robert!

[Sihui Liu]

Created attachment 456427 [details]
Patch for landing

[EWS]

Committed r292255 (249153@main): <https://commits.webkit.org/249153@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456427 [details].