NEW 23853
DOMSelection does not need a "type" member 
https://bugs.webkit.org/show_bug.cgi?id=23853
Summary DOMSelection does not need a "type" member
Eric Seidel (no email)
Reported 2009-02-09 13:58:51 PST
DOMSelection does not need a "type" member http://trac.webkit.org/browser/trunk/WebCore/page/DOMSelection.idl Mozilla's doesn't have one: https://developer.mozilla.org/En/DOM/Selection I don't think ours should either. We'd have to add a new type when we add multi-range selection support anyway... If anyone disagrees, I'd like to know. I'll post a patch shortly.
Attachments
Patch. (3.10 KB, patch)
2012-05-30 02:27 PDT, Antaryami Pandia (apandia) 		rniwa: review-
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-04 (627.35 KB, application/zip)
2012-05-30 07:53 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Justin Garcia
Comment 1 2009-02-09 14:11:30 PST
type is a IE extension http://msdn.microsoft.com/en-us/library/ms534692(VS.85).aspx although, in IE its three possible values are none, text, and control...
Eric Seidel (no email)
Comment 2 2009-05-03 15:42:10 PDT
In later patches I've added a comment to our type() code which notes that our values are incompatible with IE's.
Ryosuke Niwa
Comment 3 2012-05-30 00:45:31 PDT
It appears to me that we should just get rid of this property. It's inconsistent with IE's and it's not standardized anywhere.
Antaryami Pandia (apandia)
Comment 4 2012-05-30 02:27:25 PDT
Created attachment 144764 [details] Patch.
WebKit Review Bot
Comment 5 2012-05-30 07:53:36 PDT
Comment on attachment 144764 [details] Patch. Attachment 144764 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12853606 New failing tests: editing/selection/5497643.html editing/selection/5779984-1.html editing/selection/empty-cell-right-click.html editing/selection/context-menu-text-selection.html fast/forms/shadow-tree-exposure.html
WebKit Review Bot
Comment 6 2012-05-30 07:53:40 PDT
Created attachment 144814 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Ryosuke Niwa
Comment 7 2012-05-30 09:41:34 PDT
Comment on attachment 144764 [details] Patch. It appears that there are some tests that depend on this attribute. We need to "fix" those tests as well.
Ojan Vafai
Comment 8 2012-05-30 09:51:39 PDT
Since this is removing a web-facing feature, I believe you now need to email webkit-dev first.
Ryosuke Niwa
Comment 9 2012-05-30 10:14:36 PDT
(In reply to comment #8) > Since this is removing a web-facing feature, I believe you now need to email webkit-dev first. Yes. See http://trac.webkit.org/wiki/DeprecatingFeatures
Antaryami Pandia (apandia)
Comment 10 2012-05-30 21:36:22 PDT
(In reply to comment #9) > (In reply to comment #8) > > Since this is removing a web-facing feature, I believe you now need to email webkit-dev first. > > Yes. See http://trac.webkit.org/wiki/DeprecatingFeatures Thanks for the information. I will send an email to webkit dev first.
Antaryami Pandia (apandia)
Comment 11 2012-06-01 04:01:34 PDT
(In reply to comment #7) > (From update of attachment 144764 [details]) > It appears that there are some tests that depend on this attribute. We need to "fix" those tests as well. Yes. I am working to fix these failing tests. Once done I will upload the patch.
Note You need to log in before you can comment on or make changes to this bug.