Bug 23852 – Rename Selection to VisibleSelection in preparation for adding new Selection class

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Eric Seidel (no email)]

Rename Selection to VisibleSelection in preparation for adding new Selection class

VisibleSeleciton will eventually hold VisiblePositions instead of Positions, and Selection will hold Ranges.

The patch is just search/replace and mostly needs a rubber stamp.

[Eric Seidel (no email)]

Created attachment 27491 [details]
First pass at s/Selection/VisibleSelection

 WebCore/ChangeLog                                  |  248 ++++++++
 WebCore/WebCore.base.exp                           |   15 +-
 WebCore/WebCore.pro                                |    2 +-
 WebCore/WebCore.scons                              |    2 +-
 WebCore/WebCore.vcproj/WebCore.vcproj              |   16 +-
 WebCore/WebCore.xcodeproj/project.pbxproj          |   16 +-
 WebCore/dom/Element.cpp                            |    2 +-
 WebCore/editing/ApplyStyleCommand.cpp              |    4 +-
 WebCore/editing/BreakBlockquoteCommand.cpp         |    6 +-
 WebCore/editing/CompositeEditCommand.cpp           |   18 +-
 WebCore/editing/CompositeEditCommand.h             |    2 +-
 WebCore/editing/CreateLinkCommand.cpp              |    2 +-
 WebCore/editing/DeleteButtonController.cpp         |    4 +-
 WebCore/editing/DeleteButtonController.h           |    4 +-
 WebCore/editing/DeleteSelectionCommand.cpp         |    8 +-
 WebCore/editing/DeleteSelectionCommand.h           |    6 +-
 WebCore/editing/EditCommand.cpp                    |    4 +-
 WebCore/editing/EditCommand.h                      |   14 +-
 WebCore/editing/Editor.cpp                         |   54 +-
 WebCore/editing/Editor.h                           |   10 +-
 WebCore/editing/EditorCommand.cpp                  |   12 +-
 WebCore/editing/FormatBlockCommand.cpp             |    4 +-
 WebCore/editing/IndentOutdentCommand.cpp           |   12 +-
 WebCore/editing/InsertLineBreakCommand.cpp         |   12 +-
 WebCore/editing/InsertListCommand.cpp              |    6 +-
 .../editing/InsertParagraphSeparatorCommand.cpp    |    8 +-
 WebCore/editing/InsertTextCommand.cpp              |    8 +-
 WebCore/editing/ModifySelectionListLevel.cpp       |    6 +-
 WebCore/editing/MoveSelectionCommand.cpp           |    4 +-
 WebCore/editing/RemoveFormatCommand.cpp            |    2 +-
 WebCore/editing/ReplaceSelectionCommand.cpp        |   12 +-
 WebCore/editing/Selection.cpp                      |  651 -------------------
 WebCore/editing/Selection.h                        |  146 -----
 WebCore/editing/SelectionController.cpp            |   32 +-
 WebCore/editing/SelectionController.h              |   10 +-
 WebCore/editing/TypingCommand.cpp                  |   32 +-
 WebCore/editing/TypingCommand.h                    |    2 +-
 WebCore/editing/VisiblePosition.cpp                |    4 +-
 WebCore/editing/VisibleSelection.cpp               |  652 ++++++++++++++++++++
 WebCore/editing/VisibleSelection.h                 |  147 +++++
 WebCore/editing/htmlediting.cpp                    |   16 +-
 WebCore/editing/htmlediting.h                      |    6 +-
 WebCore/editing/markup.cpp                         |    4 +-
 WebCore/html/HTMLInputElement.cpp                  |    4 +-
 WebCore/html/HTMLInputElement.h                    |    4 +-
 WebCore/html/HTMLTextAreaElement.cpp               |    6 +-
 WebCore/html/HTMLTextAreaElement.h                 |    4 +-
 WebCore/page/AccessibilityObject.cpp               |    6 +-
 WebCore/page/AccessibilityObject.h                 |    4 +-
 WebCore/page/AccessibilityRenderObject.cpp         |   10 +-
 WebCore/page/AccessibilityRenderObject.h           |    4 +-
 WebCore/page/DOMSelection.cpp                      |   24 +-
 WebCore/page/DOMSelection.h                        |    6 +-
 WebCore/page/DragController.cpp                    |   12 +-
 WebCore/page/EditorClient.h                        |    2 +-
 WebCore/page/EventHandler.cpp                      |   28 +-
 WebCore/page/Frame.cpp                             |   40 +-
 WebCore/page/Frame.h                               |   16 +-
 WebCore/page/Page.cpp                              |    2 +-
 WebCore/page/Page.h                                |    4 +-
 WebCore/page/mac/AccessibilityObjectWrapper.mm     |    2 +-
 WebCore/rendering/RenderBlock.cpp                  |    2 +-
 WebCore/rendering/RenderTextControl.cpp            |    6 +-
 WebCore/rendering/RenderTextControl.h              |    4 +-
 WebCore/rendering/RenderTreeAsText.cpp             |    2 +-
 WebCore/rendering/RootInlineBox.cpp                |    2 +-
 WebCore/svg/SVGTextContentElement.cpp              |    2 +-
 WebKit/mac/ChangeLog                               |   14 +
 WebKit/mac/WebView/WebFrame.mm                     |    2 +-
 WebKit/mac/WebView/WebView.mm                      |    2 +-
 70 files changed, 1351 insertions(+), 1088 deletions(-)

[Dave Hyatt]

Comment on attachment 27491 [details]
First pass at s/Selection/VisibleSelection

r=me

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	R	WebCore/editing/Selection.cpp => WebCore/editing/VisibleSelection.cpp
	R	WebCore/editing/Selection.h => WebCore/editing/VisibleSelection.h
	M	WebCore/ChangeLog
	M	WebCore/WebCore.base.exp
	M	WebCore/WebCore.pro
	M	WebCore/WebCore.scons
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/dom/Element.cpp
	M	WebCore/editing/ApplyStyleCommand.cpp
	M	WebCore/editing/BreakBlockquoteCommand.cpp
	M	WebCore/editing/CompositeEditCommand.cpp
	M	WebCore/editing/CompositeEditCommand.h
	M	WebCore/editing/CreateLinkCommand.cpp
	M	WebCore/editing/DeleteButtonController.cpp
	M	WebCore/editing/DeleteButtonController.h
	M	WebCore/editing/DeleteSelectionCommand.cpp
	M	WebCore/editing/DeleteSelectionCommand.h
	M	WebCore/editing/EditCommand.cpp
	M	WebCore/editing/EditCommand.h
	M	WebCore/editing/Editor.cpp
	M	WebCore/editing/Editor.h
	M	WebCore/editing/EditorCommand.cpp
	M	WebCore/editing/FormatBlockCommand.cpp
	M	WebCore/editing/IndentOutdentCommand.cpp
	M	WebCore/editing/InsertLineBreakCommand.cpp
	M	WebCore/editing/InsertListCommand.cpp
	M	WebCore/editing/InsertParagraphSeparatorCommand.cpp
	M	WebCore/editing/InsertTextCommand.cpp
	M	WebCore/editing/ModifySelectionListLevel.cpp
	M	WebCore/editing/MoveSelectionCommand.cpp
	M	WebCore/editing/RemoveFormatCommand.cpp
	M	WebCore/editing/ReplaceSelectionCommand.cpp
	M	WebCore/editing/SelectionController.cpp
	M	WebCore/editing/SelectionController.h
	M	WebCore/editing/TypingCommand.cpp
	M	WebCore/editing/TypingCommand.h
	M	WebCore/editing/VisiblePosition.cpp
	M	WebCore/editing/htmlediting.cpp
	M	WebCore/editing/htmlediting.h
	M	WebCore/editing/markup.cpp
	M	WebCore/html/HTMLInputElement.cpp
	M	WebCore/html/HTMLInputElement.h
	M	WebCore/html/HTMLTextAreaElement.cpp
	M	WebCore/html/HTMLTextAreaElement.h
	M	WebCore/page/AccessibilityObject.cpp
	M	WebCore/page/AccessibilityObject.h
	M	WebCore/page/AccessibilityRenderObject.cpp
	M	WebCore/page/AccessibilityRenderObject.h
	M	WebCore/page/DOMSelection.cpp
	M	WebCore/page/DOMSelection.h
	M	WebCore/page/DragController.cpp
	M	WebCore/page/EditorClient.h
	M	WebCore/page/EventHandler.cpp
	M	WebCore/page/Frame.cpp
	M	WebCore/page/Frame.h
	M	WebCore/page/Page.cpp
	M	WebCore/page/Page.h
	M	WebCore/page/mac/AccessibilityObjectWrapper.mm
	M	WebCore/rendering/RenderBlock.cpp
	M	WebCore/rendering/RenderTextControl.cpp
	M	WebCore/rendering/RenderTextControl.h
	M	WebCore/rendering/RenderTreeAsText.cpp
	M	WebCore/rendering/RootInlineBox.cpp
	M	WebCore/svg/SVGTextContentElement.cpp
	M	WebKit/mac/ChangeLog
	M	WebKit/mac/WebView/WebFrame.mm
	M	WebKit/mac/WebView/WebView.mm
Committed r40793