Bug 238511 - AXIsolatedObject::isAccessibilityObject should not be ASSERT_NOT_REACHED
Summary: AXIsolatedObject::isAccessibilityObject should not be ASSERT_NOT_REACHED
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-29 09:55 PDT by Tyler Wilcock
Modified: 2022-03-29 17:33 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.70 KB, patch)
2022-03-29 09:59 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-03-29 09:55:05 PDT 
We try to downcast AXCoreObjects to AccessibilityObjects here in AXLogger's TextStream& operator<<(TextStream&, const AXCoreObject&):

if (auto* axObject = dynamicDowncast<AccessibilityObject>(&object); axObject && axObject->hasDisplayContents())
    stream.dumpProperty("hasDisplayContents", true);
Comment 1 Radar WebKit Bug Importer 2022-03-29 09:55:16 PDT 
<rdar://problem/90988646>
Comment 2 Tyler Wilcock 2022-03-29 09:59:23 PDT 
Created attachment 456036 [details]
Patch
Comment 3 EWS 2022-03-29 17:33:30 PDT 
Committed r292085 (249012@main): <https://commits.webkit.org/249012@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456036 [details].