RESOLVED FIXED 238510
[LibWPE] Guard libxkbcommon code with WPE_ENABLE_XKB 
https://bugs.webkit.org/show_bug.cgi?id=238510
Summary [LibWPE] Guard libxkbcommon code with WPE_ENABLE_XKB
Don Olmstead
Reported 2022-03-29 09:53:40 PDT
libwpe added an ENABLE flag for support of XKB.
Attachments
Patch (5.45 KB, patch)
2022-03-29 10:05 PDT, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.45 KB, patch)
2022-03-29 10:19 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2022-03-29 10:05:47 PDT Comment hidden (obsolete)
Don Olmstead
Comment 2 2022-03-29 10:19:06 PDT
Created attachment 456040 [details] Patch
Adrian Perez
Comment 3 2022-03-29 12:31:39 PDT
Comment on attachment 456040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456040&action=review > Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp:152 > struct wpe_input_xkb_keymap_entry* entries; Meh. Too bad we don't have something like GUniqueOutPtr which would call free() instead of g_free(); it would have been perfect to use here instead of having the one line of guarded code below 🤷‍♂️️
EWS
Comment 4 2022-03-29 13:26:00 PDT
Committed r292064 (248998@main): <https://commits.webkit.org/248998@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456040 [details].
Radar WebKit Bug Importer
Comment 5 2022-03-29 13:27:16 PDT
<rdar://problem/91001968>
Note You need to log in before you can comment on or make changes to this bug.