Bug 238490 - Handle pkg_config and declare_args statements in gni-to-cmake.py
Summary: Handle pkg_config and declare_args statements in gni-to-cmake.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-28 22:46 PDT by Kenneth Russell
Modified: 2022-03-29 12:10 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.36 KB, patch)
2022-03-28 22:57 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2022-03-28 22:46:04 PDT 
The Source/ThirdParty/ANGLE/gni-to-cmake.py script doesn't currently handle GN's pkg_config and declare_args statements. They don't need to be fully parsed; simply removing them will eliminate some of the manual fixups needed during each ANGLE roll.
Comment 1 Kenneth Russell 2022-03-28 22:57:10 PDT 
Created attachment 455999 [details]
Patch
Comment 2 EWS Watchlist 2022-03-28 22:58:49 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 EWS 2022-03-29 12:09:19 PDT 
Committed r292053 (248990@main): <https://commits.webkit.org/248990@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455999 [details].
Comment 4 Radar WebKit Bug Importer 2022-03-29 12:10:19 PDT 
<rdar://problem/90997571>